-
Notifications
You must be signed in to change notification settings - Fork 13.3k
pattern_analysis: Move constructor selection logic to PlaceInfo
#120692
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
pattern_analysis: Move constructor selection logic to PlaceInfo
#120692
Conversation
This comment has been minimized.
This comment has been minimized.
2b2a74c
to
adbc048
Compare
This is slower but also not a performance-sensitive path.
This gets rid of `report_individual_missing_ctors`
adbc048
to
778c7e1
Compare
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (bcea3cb): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 638.786s -> 639.837s (0.16%) |
This is a small refactor PR. There was a dense bit of constructor-related logic in
compute_exhaustiveness_and_usefulness
. I'm moving it out into aPlaceInfo
method to make it easier to follow both separately. I also have plans that will complicate it further so it's good that it's somewhat encapsulated.r? @compiler-errors