Skip to content

Update stdarch submodule #121185

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Update stdarch submodule #121185

merged 1 commit into from
Feb 19, 2024

Conversation

GuillaumeGomez
Copy link
Member

I'm syncing the rustc_codegen_gcc backend currently and it seems that the new rustc version we use is not happy with the current stdarch submodule version: https://github.com/rust-lang/rustc_codegen_gcc/actions/runs/7930753019/job/21653642490?pr=439

r? @Amanieu

@rustbot
Copy link
Collaborator

rustbot commented Feb 16, 2024

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 16, 2024
@Amanieu
Copy link
Member

Amanieu commented Feb 16, 2024

I just merged some PRs, can you update the submodule to the latest master?

@GuillaumeGomez
Copy link
Member Author

Sure, done!

@Amanieu
Copy link
Member

Amanieu commented Feb 19, 2024

There's been a few more updates on stdarch, can you update again?

@GuillaumeGomez
Copy link
Member Author

Done!

@Amanieu
Copy link
Member

Amanieu commented Feb 19, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 19, 2024

📌 Commit 9f3f2cd has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 19, 2024
@RalfJung
Copy link
Member

@bors p=1
(submodule / tool update, unblocking other work)

@bors
Copy link
Collaborator

bors commented Feb 19, 2024

⌛ Testing commit 9f3f2cd with merge 3246e79...

@bors
Copy link
Collaborator

bors commented Feb 19, 2024

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing 3246e79 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 19, 2024
@bors bors merged commit 3246e79 into rust-lang:master Feb 19, 2024
@rustbot rustbot added this to the 1.78.0 milestone Feb 19, 2024
@GuillaumeGomez GuillaumeGomez deleted the update-stdarch branch February 19, 2024 22:46
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3246e79): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.1% [0.1%, 0.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.3% [-0.3%, -0.3%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.8% [2.8%, 2.8%] 1
Regressions ❌
(secondary)
3.4% [2.3%, 4.8%] 5
Improvements ✅
(primary)
-3.3% [-3.3%, -3.3%] 1
Improvements ✅
(secondary)
-2.6% [-3.9%, -1.2%] 2
All ❌✅ (primary) -0.2% [-3.3%, 2.8%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 640.03s -> 639.676s (-0.06%)
Artifact size: 308.82 MiB -> 308.81 MiB (-0.00%)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants