Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Give some intrinsics fallback bodies #121192

Merged
merged 2 commits into from
Feb 17, 2024
Merged

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Feb 16, 2024

cc #93145

@rustbot
Copy link
Collaborator

rustbot commented Feb 16, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 16, 2024
@WaffleLapkin
Copy link
Member

r? WaffleLapkin

@rust-log-analyzer

This comment has been minimized.

@WaffleLapkin
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 16, 2024

📌 Commit dd40a80 has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 17, 2024
Rollup of 8 pull requests

Successful merges:

 - rust-lang#119032 (Use a hardcoded constant instead of calling OpenProcessToken.)
 - rust-lang#120932 (const_mut_refs: allow mutable pointers to statics)
 - rust-lang#121059 (Add and use a simple extension trait derive macro in the compiler)
 - rust-lang#121135 (coverage: Discard spans that fill the entire function body)
 - rust-lang#121187 (Add examples to document the return type of quickselect functions)
 - rust-lang#121191 (Add myself to review rotation (and a rustbot ping))
 - rust-lang#121192 (Give some intrinsics fallback bodies)
 - rust-lang#121197 (Ensure `./configure` works when `configure.py` path contains spaces)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 936b666 into rust-lang:master Feb 17, 2024
11 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Feb 17, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 17, 2024
Rollup merge of rust-lang#121192 - oli-obk:intrinsics2.0, r=WaffleLapkin

Give some intrinsics fallback bodies

cc rust-lang#93145
celinval added a commit to celinval/rust-dev that referenced this pull request Jul 4, 2024
Move a few more intrinsic functions to the convention added in rust-lang#121192
where they have Rust abi but are tagged with `rustc_intrinsic`.

Additionally, document their safety requirements.
celinval added a commit to celinval/rust-dev that referenced this pull request Jul 4, 2024
Move a few more intrinsic functions to the convention added in rust-lang#121192
where they have Rust abi but are tagged with `rustc_intrinsic`.
celinval added a commit to celinval/rust-dev that referenced this pull request Jul 4, 2024
Move a few more intrinsic functions to the convention added in rust-lang#121192
where they have Rust abi but are tagged with `rustc_intrinsic`.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 17, 2024
…i-obk

Move a few intrinsics to Rust abi

Move a few more intrinsic functions to the convention added in rust-lang#121192. In the second commit, I added documentation about their safety requirements. Let me know if you would like me to move the second commit to a different PR.

Note: I kept the same signature of `pref_align_of`, but I was wondering why this function is considered unsafe?
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 18, 2024
Rollup merge of rust-lang#127337 - celinval:intrinsics-fallback, r=oli-obk

Move a few intrinsics to Rust abi

Move a few more intrinsic functions to the convention added in rust-lang#121192. In the second commit, I added documentation about their safety requirements. Let me know if you would like me to move the second commit to a different PR.

Note: I kept the same signature of `pref_align_of`, but I was wondering why this function is considered unsafe?
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants