Skip to content

Solaris linker does not support --strip-debug #121399

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

psumbera
Copy link
Contributor

Fixes #121381

@rustbot
Copy link
Collaborator

rustbot commented Feb 21, 2024

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 21, 2024
@psumbera
Copy link
Contributor Author

Ideally if this can go also to beta.

@psumbera psumbera force-pushed the solaris-strip-debug branch from 65fd146 to a17211b Compare February 21, 2024 15:51
@Nadrieril
Copy link
Member

Hi! I'm not competent on target shenanigans. @petrochenkov wanna take this?

@petrochenkov
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 21, 2024

📌 Commit a17211b has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 21, 2024
@ehuss ehuss added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 21, 2024
@Nadrieril Nadrieril assigned petrochenkov and unassigned Nadrieril Feb 21, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 21, 2024
…trochenkov

Solaris linker does not support --strip-debug

Fixes rust-lang#121381
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 21, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#119636 (os::net: expanding TcpStreamExt for Linux with `tcp_deferaccept`.)
 - rust-lang#121261 (coverage: Remove `pending_dups` from the span refiner)
 - rust-lang#121336 (triagebot: add queue notifications)
 - rust-lang#121391 (never patterns: Fix liveness analysis in the presence of never patterns)
 - rust-lang#121399 (Solaris linker does not support --strip-debug)
 - rust-lang#121406 (Add a couple tests)

Failed merges:

 - rust-lang#121206 (Top level error handling)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 22, 2024
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#121206 (Top level error handling)
 - rust-lang#121261 (coverage: Remove `pending_dups` from the span refiner)
 - rust-lang#121336 (triagebot: add queue notifications)
 - rust-lang#121373 (Consistently refer to a test's `revision` instead of `cfg`)
 - rust-lang#121391 (never patterns: Fix liveness analysis in the presence of never patterns)
 - rust-lang#121392 (Unify dylib loading between proc macros and codegen backends)
 - rust-lang#121399 (Solaris linker does not support --strip-debug)
 - rust-lang#121406 (Add a couple tests)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8ab24c9 into rust-lang:master Feb 22, 2024
@rustbot rustbot added this to the 1.78.0 milestone Feb 22, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 22, 2024
Rollup merge of rust-lang#121399 - psumbera:solaris-strip-debug, r=petrochenkov

Solaris linker does not support --strip-debug

Fixes rust-lang#121381
@apiraino
Copy link
Contributor

Beta backport approved as per compiler team on Zulip

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Feb 22, 2024
@cuviper cuviper mentioned this pull request Mar 4, 2024
@cuviper cuviper modified the milestones: 1.78.0, 1.77.0 Mar 4, 2024
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 4, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 6, 2024
[beta] backports

- Improve wording of `static_mut_ref` rust-lang#121034
- Solaris linker does not support --strip-debug rust-lang#121399

r? cuviper
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linking issue on Solaris - ld: fatal: unrecognized option --strip-debug
8 participants