-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Dummy tweaks (attempt 2) #121829
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Dummy tweaks (attempt 2) #121829
Conversation
@petrochenkov: you added the |
Removing it seems brittle. |
691e788
to
e95e83a
Compare
Ok, I have removed the old second commit that removes |
They are exactly the same purpose though, create some node that will just sit in AST during error recovery. The UPD: to clarify, the trait renaming also doesn't look useful to me. |
So the purpose is much the same, but the details vary greatly. This is why I removed the interdependency. You could probably frankenstein them into a single thing (trait? type?) that can be used in both cases, by adding extra parameters, but I think that would end up being less clear. |
They are two different ways of creating dummy results, with two different purposes. Their implementations are separate except for crates, where `DummyResult` depends on `DummyAstNode`. This commit removes that dependency, so they are now fully separate. It also expands the comment on `DummyAstNode`.
e95e83a
to
a9dff2d
Compare
I have removed the third commit. I think the first two commits are still worth doing, and that @rustbot review |
@bors r+ rollup |
I've just learned about Considering the reasons for its introduction, fundamentally there should be 3 flavors of dummy AST nodes:
Both |
…ochenkov Dummy tweaks (attempt 2) r? `@petrochenkov`
…ochenkov Dummy tweaks (attempt 2) r? ``@petrochenkov``
…ochenkov Dummy tweaks (attempt 2) r? ```@petrochenkov```
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#121065 (Add basic i18n guidance for `Display`) - rust-lang#121301 (errors: share `SilentEmitter` between rustc and rustfmt) - rust-lang#121744 (Stop using Bubble in coherence and instead emulate it with an intercrate check) - rust-lang#121829 (Dummy tweaks (attempt 2)) - rust-lang#121857 (Implement async closure signature deduction) - rust-lang#121894 (const_eval_select: make it safe but be careful with what we expose on stable for now) - rust-lang#121905 (Add a `description` field to target definitions) - rust-lang#122022 (loongarch: add frecipe and relax target feature) - rust-lang#122028 (Remove some dead code) r? `@ghost` `@rustbot` modify labels: rollup
…ochenkov Dummy tweaks (attempt 2) r? ````@petrochenkov````
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#121065 (Add basic i18n guidance for `Display`) - rust-lang#121744 (Stop using Bubble in coherence and instead emulate it with an intercrate check) - rust-lang#121829 (Dummy tweaks (attempt 2)) - rust-lang#121832 (Add new Tier-3 target: `loongarch64-unknown-linux-musl`) - rust-lang#121857 (Implement async closure signature deduction) - rust-lang#121894 (const_eval_select: make it safe but be careful with what we expose on stable for now) - rust-lang#122014 (Change some attributes to only_local.) - rust-lang#122016 (will_wake tests fail on Miri and that is expected) - rust-lang#122018 (only set noalias on Box with the global allocator) - rust-lang#122028 (Remove some dead code) r? `@ghost` `@rustbot` modify labels: rollup
Those special node kinds have evolved over time, and could certainly be adjusted and made more uniform. |
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#121065 (Add basic i18n guidance for `Display`) - rust-lang#121744 (Stop using Bubble in coherence and instead emulate it with an intercrate check) - rust-lang#121829 (Dummy tweaks (attempt 2)) - rust-lang#121857 (Implement async closure signature deduction) - rust-lang#121894 (const_eval_select: make it safe but be careful with what we expose on stable for now) - rust-lang#122014 (Change some attributes to only_local.) - rust-lang#122016 (will_wake tests fail on Miri and that is expected) - rust-lang#122018 (only set noalias on Box with the global allocator) - rust-lang#122028 (Remove some dead code) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#121065 (Add basic i18n guidance for `Display`) - rust-lang#121744 (Stop using Bubble in coherence and instead emulate it with an intercrate check) - rust-lang#121829 (Dummy tweaks (attempt 2)) - rust-lang#121857 (Implement async closure signature deduction) - rust-lang#121894 (const_eval_select: make it safe but be careful with what we expose on stable for now) - rust-lang#122014 (Change some attributes to only_local.) - rust-lang#122016 (will_wake tests fail on Miri and that is expected) - rust-lang#122018 (only set noalias on Box with the global allocator) - rust-lang#122028 (Remove some dead code) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#121829 - nnethercote:dummy-tweaks-2, r=petrochenkov Dummy tweaks (attempt 2) r? `````@petrochenkov`````
Sorry @petrochenkov for not including you in the discussions around |
r? @petrochenkov