Skip to content

Modify opt-dist logic for finding LLVM artifacts #121866

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Mar 1, 2024

This is the rustc side of fixing #121395 (comment).

@rustbot
Copy link
Collaborator

rustbot commented Mar 1, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 1, 2024
@Mark-Simulacrum
Copy link
Member

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Mar 7, 2024

📌 Commit 31ae823 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 7, 2024
@bors
Copy link
Collaborator

bors commented Mar 7, 2024

⌛ Testing commit 31ae823 with merge 51f4839...

@bors
Copy link
Collaborator

bors commented Mar 7, 2024

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 51f4839 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 7, 2024
@bors bors merged commit 51f4839 into rust-lang:master Mar 7, 2024
@rustbot rustbot added this to the 1.78.0 milestone Mar 7, 2024
@Kobzol Kobzol deleted the opt-dist-find-llvm branch March 7, 2024 10:31
@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 7, 2024

Same as rust-lang/rustc-perf#1830, this now only finds the 43B file.. :(

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (51f4839): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.0% [-3.0%, -3.0%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -3.0% [-3.0%, -3.0%] 1

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.6% [2.4%, 2.7%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 646.956s -> 647.185s (0.04%)
Artifact size: 172.64 MiB -> 172.72 MiB (0.04%)

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Mar 7, 2024
…rk-Simulacrum

Include all library files in artifact summary on CI

It's not worth it to maintain any custom logic here. Just print all files in the `lib` directory, this should be forward compatible.

This fixes rust-lang#121866, based on rust-lang#121967.

r? `@Mark-Simulacrum`
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 8, 2024
Rollup merge of rust-lang#122136 - Kobzol:opt-dist-lookup-logic, r=Mark-Simulacrum

Include all library files in artifact summary on CI

It's not worth it to maintain any custom logic here. Just print all files in the `lib` directory, this should be forward compatible.

This fixes rust-lang#121866, based on rust-lang#121967.

r? `@Mark-Simulacrum`
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants