Rollup of 5 pull requests #121955

matthiaskrgr · 2024-03-03T21:56:15Z

Successful merges:

Move some tests #121248 (Move some tests)
Consider middle segments of paths in unused_qualifications #121528 (Consider middle segments of paths in unused_qualifications)
Don't lint on executable crates with non_snake_case names #121749 (Don't lint on executable crates with non_snake_case names)
library/ptr: mention that ptr::without_provenance is equivalent to deriving from the null ptr #121935 (library/ptr: mention that ptr::without_provenance is equivalent to deriving from the null ptr)
Run some ui-fulldeps tests on stage 1 again #121945 (Run some ui-fulldeps tests on stage 1 again)

r? @ghost
@rustbot modify labels: rollup

Co-authored-by: Jieyou Xu <jieyouxu@outlook.com>

…riving from the null ptr

We're trying to test lint behavior, not per-target crate-type support.

This is the second time I'm doing this... I'm starting to feel like stage1 ui-fulldeps tests were a mistake. Maybe I should have just put `#[cfg(bootstrap)]` there to let the bootstrap bumper fix it.

Move some tests r? `@petrochenkov`

…=petrochenkov Consider middle segments of paths in `unused_qualifications` Currently `unused_qualifications` looks at the last segment of a path to see if it can be trimmed, this PR extends the check to the middle segments also ```rust // currently linted use std::env::args(); std::env::args(); // Removes `std::env::` ``` ```rust // newly linted use std::env; std::env::args(); // Removes `std::` ``` Paths with generics in them are now linted as long as the part being trimmed is before any generic args, e.g. it will now suggest trimming `std::vec::` from `std::vec::Vec<usize>` Paths with any segments that are from an expansion are no longer linted Fixes rust-lang#100979 Fixes rust-lang#96698

…henkov Don't lint on executable crates with `non_snake_case` names Revives rust-lang#111130, cc `@GilShoshan94.` Closes rust-lang#45127.

library/ptr: mention that ptr::without_provenance is equivalent to deriving from the null ptr This might help clarify why you can't do memory accesses with it.

…r-errors Run some ui-fulldeps tests on stage 1 again This is the second time I'm doing this... I'm starting to feel like stage1 ui-fulldeps tests were a mistake. Maybe I should have just put `#[cfg(bootstrap)]` there to let the bootstrap bumper fix it. `@George-lewis` :) finishes rust-lang#119088 (comment)

matthiaskrgr · 2024-03-03T21:56:32Z

@bors r+ rollup=never p=5

bors · 2024-03-03T21:56:34Z

📌 Commit e5a6d21 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2024-03-03T22:14:33Z

⌛ Testing commit e5a6d21 with merge 3fb9000...

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#121248 (Move some tests) - rust-lang#121528 (Consider middle segments of paths in `unused_qualifications`) - rust-lang#121749 (Don't lint on executable crates with `non_snake_case` names) - rust-lang#121935 (library/ptr: mention that ptr::without_provenance is equivalent to deriving from the null ptr) - rust-lang#121945 (Run some ui-fulldeps tests on stage 1 again) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-03-03T22:20:47Z

💔 Test failed - checks-actions

rust-log-analyzer · 2024-03-03T22:21:36Z

The job x86_64-apple-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

SCRIPT=./x.py --stage 2 test --skip tests/ui --skip tests/rustdoc --skip tests/run-make-fulldeps
SELECT_XCODE=/Applications/Xcode_14.3.1.app
SHELL=/bin/bash
SHLVL=3
SSH_AUTH_SOCK=/private/tmp/com.apple.launchd.NxRyxmS5Cx/Listeners
STATS_EXTP=https://provjobdsettingscdn.blob.core.windows.net/settings/provjobdsettings-0.5.154/provjobd.data
STATS_RDCL=true
STATS_TIS=mining
STATS_TRP=true

matthiaskrgr · 2024-03-03T22:21:50Z

@bors retry
warning: spurious network error (2 tries remaining): [6] Couldn't resolve host name (Could not resolve host: index.crates.io)

bors · 2024-03-04T00:37:23Z

⌛ Testing commit e5a6d21 with merge 89b7830...

bors · 2024-03-04T03:02:28Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 89b7830 to master...

rust-timer · 2024-03-04T03:03:53Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#121248	Move some tests	`176f251a3d3988f418816f67d7363d5efb92e2bf` (link)
#121528	Consider middle segments of paths in `unused_qualifications`	`f6ee0c0d7e340bf27eed847964571921caafed7c` (link)
#121749	Don't lint on executable crates with `non_snake_case` names	`cdb0b9aee0b3d705ad580a3b66bb122738653c08` (link)
#121935	library/ptr: mention that ptr::without_provenance is equiva…	`cfb38919908ebc22b7d041275c9378b6293cb1d1` (link)
#121945	Run some ui-fulldeps tests on stage 1 again	`7c81387458f1b94b2435e96eaacb696ed407299d` (link)

previous master: 70aa0b86c0

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-03-04T04:16:07Z

Finished benchmarking commit (89b7830): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.2%, 3.7%]	17
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.8%, -0.2%]	10
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[-0.8%, 3.7%]	27

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.6%	[1.6%, 1.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.7%	[3.7%, 3.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.7%	[3.7%, 3.7%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 644.02s -> 643.72s (-0.05%)
Artifact size: 174.95 MiB -> 175.01 MiB (0.03%)

Kobzol · 2024-03-04T06:34:20Z

@rust-timer build f6ee0c0

rust-timer · 2024-03-04T08:23:39Z

Finished benchmarking commit (f6ee0c0): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.3%, 2.6%]	14
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.8%, -0.2%]	11
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[-0.8%, 2.6%]	25

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-4.6%	[-4.6%, -4.6%]	1
Improvements ✅ (secondary)	-2.4%	[-2.8%, -2.1%]	2
All ❌✅ (primary)	-4.6%	[-4.6%, -4.6%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.4%	[2.4%, 2.4%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.4%	[2.4%, 2.4%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 644.02s -> 643.036s (-0.15%)
Artifact size: 174.95 MiB -> 175.00 MiB (0.03%)

Kobzol · 2024-03-04T08:28:36Z

Looks like the regressions come from #121528. It seems to be a correctness fix, so I think it's fine, but just CCing @petrochenkov to check if this is expected.

GilShoshan94 and others added 14 commits February 28, 2024 16:55

Don't lint snake-case on executable crate name

bf8756d

Co-authored-by: Jieyou Xu <jieyouxu@outlook.com>

Hoist only-executables check above producing crate ident

d363db7

Ignore wasm in dylib/proc-macro crate type tests

6e355ae

library/ptr: mention that ptr::without_provenance is equivalent to de…

d579caf

…riving from the null ptr

Ignore cdylib test for i686-unknown-linux-musl

82ceec9

Only run lint tests on x86_64-unknown-linux-gnu

d0111cb

We're trying to test lint behavior, not per-target crate-type support.

Run some ui-fulldeps tests on stage 1 again

93f595f

This is the second time I'm doing this... I'm starting to feel like stage1 ui-fulldeps tests were a mistake. Maybe I should have just put `#[cfg(bootstrap)]` there to let the bootstrap bumper fix it.

Consider middle segments of paths in unused_qualifications

4ea9f72

Move tests

2aab000

Rollup merge of rust-lang#121248 - c410-f3r:testsssssss, r=petrochenkov

d37ad03

Move some tests r? `@petrochenkov`

Rollup merge of rust-lang#121749 - jieyouxu:issue-45127-fix, r=petroc…

10234fc

…henkov Don't lint on executable crates with `non_snake_case` names Revives rust-lang#111130, cc `@GilShoshan94.` Closes rust-lang#45127.

Rollup merge of rust-lang#121935 - RalfJung:ptr-without-prov, r=scottmcm

dc8b71a

library/ptr: mention that ptr::without_provenance is equivalent to deriving from the null ptr This might help clarify why you can't do memory accesses with it.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 3, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 4, 2024

bors merged commit 89b7830 into rust-lang:master Mar 4, 2024

rustbot added this to the 1.78.0 milestone Mar 4, 2024

This was referenced Mar 4, 2024

Check for occupied niches #121174

Draft

Refactor pre-getopts command line argument handling #121194

Merged

Detect unused struct impls pub trait #121752

Merged

Diagnostic renaming 2 #121780

Merged

rustbot added the perf-regression Performance regression. label Mar 4, 2024

This comment has been minimized.

# to view

matthiaskrgr deleted the rollup-1i3lo0j branch March 16, 2024 18:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 5 pull requests #121955

Rollup of 5 pull requests #121955

Uh oh!

matthiaskrgr commented Mar 3, 2024

Uh oh!

matthiaskrgr commented Mar 3, 2024

Uh oh!

bors commented Mar 3, 2024

Uh oh!

bors commented Mar 3, 2024

Uh oh!

bors commented Mar 3, 2024

Uh oh!

rust-log-analyzer commented Mar 3, 2024

Uh oh!

matthiaskrgr commented Mar 3, 2024

Uh oh!

bors commented Mar 4, 2024

Uh oh!

bors commented Mar 4, 2024

Uh oh!

rust-timer commented Mar 4, 2024

Uh oh!

rust-timer commented Mar 4, 2024

Uh oh!

Kobzol commented Mar 4, 2024

Uh oh!

This comment has been minimized.

rust-timer commented Mar 4, 2024

Uh oh!

Kobzol commented Mar 4, 2024

Uh oh!

Uh oh!

Rollup of 5 pull requests #121955

Rollup of 5 pull requests #121955

Uh oh!

Conversation

matthiaskrgr commented Mar 3, 2024

Uh oh!

matthiaskrgr commented Mar 3, 2024

Uh oh!

bors commented Mar 3, 2024

Uh oh!

bors commented Mar 3, 2024

Uh oh!

bors commented Mar 3, 2024

Uh oh!

rust-log-analyzer commented Mar 3, 2024

Uh oh!

matthiaskrgr commented Mar 3, 2024

Uh oh!

bors commented Mar 4, 2024

Uh oh!

bors commented Mar 4, 2024

Uh oh!

rust-timer commented Mar 4, 2024

Uh oh!

rust-timer commented Mar 4, 2024

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Uh oh!

Kobzol commented Mar 4, 2024

Uh oh!

This comment has been minimized.

rust-timer commented Mar 4, 2024

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Uh oh!

Kobzol commented Mar 4, 2024

Uh oh!

Uh oh!