Fix suggestion when shorthand self has erroneous type
#122161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
chenyukang
reviewed
Mar 8, 2024
rust-cloud-vms
bot
force-pushed
the
shorthand-self
branch
from
532c15e to
dc9108a
Compare
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 8, 2024
… r=workingjubilee Bless tidy issues order The order is not right now because of rust-lang#121248 (comment) from rust-lang#122161 (comment) r? `@workingjubilee`
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 8, 2024
Rollup merge of rust-lang#122175 - chenyukang:yukang-fix-tidy-issues, r=workingjubilee Bless tidy issues order The order is not right now because of rust-lang#121248 (comment) from rust-lang#122161 (comment) r? `@workingjubilee`
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Mar 9, 2024
…gjubilee Bless tidy issues order The order is not right now because of rust-lang/rust#121248 (comment) from rust-lang/rust#122161 (comment) r? `@workingjubilee`
|
Seems like @estebank is busy, so r? compiler |
|
r? @fmease |
fmease
approved these changes
Mar 19, 2024
fmease
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #124277) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@compiler-errors |
|
Ya I'll rebase it. |
alex-semenyuk
added
S-waiting-on-author
compiler-errors
force-pushed
the
shorthand-self
branch
from
dc9108a to
05c34cc
Compare
|
Finally rebased lol @bors r=fmease |
|
@bors r=fmease |
|
@bors ping |
|
😪 I'm awake I'm awake |
|
ok so if you're awake then why won't you accept my pr @bors r=fmease |
bors
added
S-waiting-on-bors
|
💡 This pull request was already approved, no need to approve it again.
|
fmease
added a commit
to fmease/rust
that referenced
this pull request
Dec 4, 2024
…fmease Fix suggestion when shorthand `self` has erroneous type Fixes rust-lang#122086 r? estebank
fmease
added a commit
to fmease/rust
that referenced
this pull request
Dec 4, 2024
…fmease Fix suggestion when shorthand `self` has erroneous type Fixes rust-lang#122086 r? estebank
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 4, 2024
Rollup of 7 pull requests Successful merges: - rust-lang#118833 (Add lint against function pointer comparisons) - rust-lang#122161 (Fix suggestion when shorthand `self` has erroneous type) - rust-lang#133233 (Add context to "const in pattern" errors) - rust-lang#133843 (Do not emit empty suggestion) - rust-lang#133863 (Rename `core_pattern_type` and `core_pattern_types` lib feature gates to `pattern_type_macro`) - rust-lang#133872 (No need to create placeholders for GAT args in confirm_object_candidate) - rust-lang#133874 (`fn_sig_for_fn_abi` should return a `ty::FnSig`, no need for a binder) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 5, 2024
Rollup of 7 pull requests Successful merges: - rust-lang#118833 (Add lint against function pointer comparisons) - rust-lang#122161 (Fix suggestion when shorthand `self` has erroneous type) - rust-lang#133233 (Add context to "const in pattern" errors) - rust-lang#133843 (Do not emit empty suggestion) - rust-lang#133863 (Rename `core_pattern_type` and `core_pattern_types` lib feature gates to `pattern_type_macro`) - rust-lang#133872 (No need to create placeholders for GAT args in confirm_object_candidate) - rust-lang#133874 (`fn_sig_for_fn_abi` should return a `ty::FnSig`, no need for a binder) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 5, 2024
Rollup of 10 pull requests Successful merges: - rust-lang#118833 (Add lint against function pointer comparisons) - rust-lang#122161 (Fix suggestion when shorthand `self` has erroneous type) - rust-lang#133233 (Add context to "const in pattern" errors) - rust-lang#133761 (Update books) - rust-lang#133843 (Do not emit empty suggestion) - rust-lang#133863 (Rename `core_pattern_type` and `core_pattern_types` lib feature gates to `pattern_type_macro`) - rust-lang#133872 (No need to create placeholders for GAT args in confirm_object_candidate) - rust-lang#133874 (`fn_sig_for_fn_abi` should return a `ty::FnSig`, no need for a binder) - rust-lang#133890 (Add a new test ui/incoherent-inherent-impls/no-other-unrelated-errors to check E0116 does not cause unrelated errors) - rust-lang#133892 (Revert rust-lang#133817) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 5, 2024
Rollup merge of rust-lang#122161 - compiler-errors:shorthand-self, r=fmease Fix suggestion when shorthand `self` has erroneous type Fixes rust-lang#122086 r? estebank
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122086
r? estebank