Skip to content

diagnostics: suggest Clone bounds when noop clone() #122174

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2024
Merged

diagnostics: suggest Clone bounds when noop clone() #122174

merged 1 commit into from
Mar 15, 2024

Conversation

notriddle
Copy link
Contributor

Fixes #121524

@notriddle notriddle marked this pull request as ready for review March 8, 2024 03:03
@rustbot
Copy link
Collaborator

rustbot commented Mar 8, 2024

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 8, 2024
@TaKO8Ki
Copy link
Member

TaKO8Ki commented Mar 15, 2024

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 15, 2024

📌 Commit c2cc904 has been approved by TaKO8Ki

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 15, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 15, 2024
@bors
Auto merge of rust-lang#122534 - matthiaskrgr:rollup-p95i3ph, r=matth…
d7723b2 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#121207 (Add `-Z external-clangrt`)
 - rust-lang#122174 (diagnostics: suggest `Clone` bounds when noop `clone()`)
 - rust-lang#122471 (preserve span when evaluating mir::ConstOperand)
 - rust-lang#122515 (Pass the correct DefId when suggesting writing the aliased Self type out)
 - rust-lang#122523 (Ensure RPITITs are created before def-id freezing)
 - rust-lang#122526 (Docs for `thir::ExprKind::Use` and `thir::ExprKind::Let`)
 - rust-lang#122527 (Clean up AstConv)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e66c7e4 into rust-lang:master Mar 15, 2024
@rustbot rustbot added this to the 1.78.0 milestone Mar 15, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 15, 2024
@rust-timer
Unrolled build for rust-lang#122174
b55500f 
Rollup merge of rust-lang#122174 - notriddle:master, r=TaKO8Ki

diagnostics: suggest `Clone` bounds when noop `clone()`

Fixes rust-lang#121524
@fmease fmease mentioned this pull request Jan 27, 2025
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@TaKO8Ki TaKO8Ki

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.

Omitting Clone bound on &impl Trait leads to correct but unhelpful error
4 participants
@notriddle @rustbot @TaKO8Ki @bors