-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Don't ICE when encountering bound regions in generator interior type #122358
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Don't ICE when encountering bound regions in generator interior type #122358
Conversation
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
maybe change it to
given the fact that nested bound regions clearly must exist, it did take me a few minutes to actually understand what this meant here. Though, given that we ICE when |
Yeah that debug assertion does nothing then. |
0df55aa
to
a79b56a
Compare
Some changes occurred in src/tools/cargo cc @ehuss |
a79b56a
to
a85dbfb
Compare
@bors r+ rollup |
This comment has been minimized.
This comment has been minimized.
lol I pushed at the same time as the r+ @bors - |
@bors r- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a "FIXME: use bound_coroutine_hidden_types
instead and work towards removing this to coroutine_hidden_types
". r=me after
a04ad8c
to
04b45db
Compare
I refuse to fix this in the old solver; its lazy instantiation of binders will be the end of me.
04b45db
to
bca708b
Compare
❤️ @bors r+ rollup |
…enerator, r=lcnr Don't ICE when encountering bound regions in generator interior type I'm pretty sure this meant to say "`has_free_regions`", probably just a typo in 4a4fc3b. We can have bound regions (because we only convert non-bound regions into existential regions in generator interiors), but we can't have (non-ReErased) free regions. r? lcnr
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#122222 (deref patterns: bare-bones feature gate and typechecking) - rust-lang#122358 (Don't ICE when encountering bound regions in generator interior type) - rust-lang#122696 (Add bare metal riscv32 target.) - rust-lang#122773 (make "expected paren or brace" error translatable) - rust-lang#122795 (Inherit `RUSTC_BOOTSTRAP` when testing wasm) - rust-lang#122799 (Replace closures with `_` when suggesting fully qualified path for method call) - rust-lang#122801 (Fix misc printing issues in emit=stable_mir) - rust-lang#122806 (Make `type_ascribe!` not a built-in) Failed merges: - rust-lang#122771 (add some comments to hir::ModuleItems) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#122358 - compiler-errors:bound-regions-in-generator, r=lcnr Don't ICE when encountering bound regions in generator interior type I'm pretty sure this meant to say "`has_free_regions`", probably just a typo in 4a4fc3b. We can have bound regions (because we only convert non-bound regions into existential regions in generator interiors), but we can't have (non-ReErased) free regions. r? lcnr
I'm pretty sure this meant to say "
has_free_regions
", probably just a typo in 4a4fc3b. We can have bound regions (because we only convert non-bound regions into existential regions in generator interiors), but we can't have (non-ReErased) free regions.r? lcnr