Gracefully handle `AnonConst` in `diagnostic_hir_wf_check()` #122370

gurry · 2024-03-12T08:47:56Z

Instead of running the WF check on the AnonConst itself we run it on the ty of the generic param of which the AnonConst is the default value.

Fixes #122199

rustbot · 2024-03-12T08:48:05Z

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

davidtwco · 2024-03-18T11:33:50Z

@bors r+

bors · 2024-03-18T11:33:53Z

📌 Commit d0e4a3b has been approved by davidtwco

It is now in the queue for this repository.

…r=davidtwco Gracefully handle `AnonConst` in `diagnostic_hir_wf_check()` Instead of running the WF check on the `AnonConst` itself we run it on the `ty` of the generic param of which the `AnonConst` is the default value. Fixes rust-lang#122199

matthiaskrgr · 2024-03-18T15:26:39Z

I think this needs a rebase

…r=davidtwco Gracefully handle `AnonConst` in `diagnostic_hir_wf_check()` Instead of running the WF check on the `AnonConst` itself we run it on the `ty` of the generic param of which the `AnonConst` is the default value. Fixes rust-lang#122199

workingjubilee · 2024-03-18T20:42:27Z

@bors r-

workingjubilee · 2024-03-18T20:44:42Z

PR is incompatible with #122513

It looks like you can "just" replace the code with hir_node_by_def_id (with the associated deoptionalizing refactor).

when it is the default value of a generic param

gurry · 2024-03-19T06:26:23Z

Rebase done.

@rustbot label -S-waiting-on-author +S-waiting-on-review

workingjubilee · 2024-03-19T18:28:43Z

This looks exactly the same so,

@bors r=davidtwco

bors · 2024-03-19T18:28:45Z

📌 Commit 3c70d60 has been approved by davidtwco

It is now in the queue for this repository.

…davidtwco Gracefully handle `AnonConst` in `diagnostic_hir_wf_check()` Instead of running the WF check on the `AnonConst` itself we run it on the `ty` of the generic param of which the `AnonConst` is the default value. Fixes rust-lang#122199

bors · 2024-03-20T04:52:29Z

⌛ Testing commit 3c70d60 with merge 67fb0d6...

bors · 2024-03-20T09:07:29Z

💥 Test timed out

rust-log-analyzer · 2024-03-20T09:38:21Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

workingjubilee · 2024-03-22T03:07:36Z

@bors retry

workingjubilee · 2024-03-22T03:08:09Z

Assuming that was spurious based on only one job hanging.

…r=davidtwco Gracefully handle `AnonConst` in `diagnostic_hir_wf_check()` Instead of running the WF check on the `AnonConst` itself we run it on the `ty` of the generic param of which the `AnonConst` is the default value. Fixes rust-lang#122199

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#121619 (Experimental feature postfix match) - rust-lang#122370 (Gracefully handle `AnonConst` in `diagnostic_hir_wf_check()`) - rust-lang#122537 (interpret/allocation: fix aliasing issue in interpreter and refactor getters a bit) - rust-lang#122542 (coverage: Clean up marker statements that aren't needed later) - rust-lang#122800 (Add `NonNull::<[T]>::is_empty`.) - rust-lang#122820 (Stop using `<DefId as Ord>` in various diagnostic situations) - rust-lang#122847 (Suggest `RUST_MIN_STACK` workaround on overflow) - rust-lang#122855 (Fix Itanium mangling usizes) - rust-lang#122863 (add more ice tests ) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#122370 - gurry:122199-ice-unexpected-node, r=davidtwco Gracefully handle `AnonConst` in `diagnostic_hir_wf_check()` Instead of running the WF check on the `AnonConst` itself we run it on the `ty` of the generic param of which the `AnonConst` is the default value. Fixes rust-lang#122199

…, r=workingjubilee Change an ICE regression test to use the original reproducer The ICE was fixed in PR rust-lang#122370, but the test used a different reproducer than the one originally reported. This PR changes it to the original one, giving us more confidence that the fix works. Fixes rust-lang#122199

Rollup merge of rust-lang#122927 - gurry:122199-ice-unexpected-node-2, r=workingjubilee Change an ICE regression test to use the original reproducer The ICE was fixed in PR rust-lang#122370, but the test used a different reproducer than the one originally reported. This PR changes it to the original one, giving us more confidence that the fix works. Fixes rust-lang#122199

…, r=workingjubilee Change an ICE regression test to use the original reproducer The ICE was fixed in PR rust-lang#122370, but the test used a different reproducer than the one originally reported. This PR changes it to the original one, giving us more confidence that the fix works. Fixes rust-lang#122199

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#121619 (Experimental feature postfix match) - rust-lang#122370 (Gracefully handle `AnonConst` in `diagnostic_hir_wf_check()`) - rust-lang#122537 (interpret/allocation: fix aliasing issue in interpreter and refactor getters a bit) - rust-lang#122542 (coverage: Clean up marker statements that aren't needed later) - rust-lang#122800 (Add `NonNull::<[T]>::is_empty`.) - rust-lang#122820 (Stop using `<DefId as Ord>` in various diagnostic situations) - rust-lang#122847 (Suggest `RUST_MIN_STACK` workaround on overflow) - rust-lang#122855 (Fix Itanium mangling usizes) - rust-lang#122863 (add more ice tests ) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned davidtwco Mar 12, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 12, 2024

gurry force-pushed the 122199-ice-unexpected-node branch from b3c7f11 to d0e4a3b Compare March 12, 2024 08:56

davidtwco approved these changes Mar 18, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2024

matthiaskrgr mentioned this pull request Mar 18, 2024

Rollup of 8 pull requests #122688

Closed

workingjubilee mentioned this pull request Mar 18, 2024

Rollup of 14 pull requests #122711

Closed

workingjubilee closed this Mar 18, 2024

workingjubilee reopened this Mar 18, 2024

This comment has been minimized.

# to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 18, 2024

Gracefully handle AnonConst in diagnostic_hir_wf_check()

3c70d60

when it is the default value of a generic param

gurry force-pushed the 122199-ice-unexpected-node branch from d0e4a3b to 3c70d60 Compare March 19, 2024 03:53

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 19, 2024

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 19, 2024

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 19, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 20, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2024

matthiaskrgr mentioned this pull request Mar 22, 2024

Rollup of 8 pull requests #122866

Closed

This was referenced Mar 22, 2024

Rollup of 7 pull requests #122867

Closed

Rollup of 9 pull requests #122869

Merged

bors merged commit f5ac009 into rust-lang:master Mar 22, 2024

rustbot added this to the 1.79.0 milestone Mar 22, 2024

gurry mentioned this pull request Mar 23, 2024

Change an ICE regression test to use the original reproducer #122927

Merged

gurry deleted the 122199-ice-unexpected-node branch April 30, 2024 10:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Gracefully handle `AnonConst` in `diagnostic_hir_wf_check()` #122370

Gracefully handle `AnonConst` in `diagnostic_hir_wf_check()` #122370

Uh oh!

gurry commented Mar 12, 2024

Uh oh!

rustbot commented Mar 12, 2024

Uh oh!

davidtwco commented Mar 18, 2024

Uh oh!

bors commented Mar 18, 2024

Uh oh!

matthiaskrgr commented Mar 18, 2024

Uh oh!

This comment has been minimized.

workingjubilee commented Mar 18, 2024

Uh oh!

workingjubilee commented Mar 18, 2024 •

edited

Loading

Uh oh!

gurry commented Mar 19, 2024

Uh oh!

workingjubilee commented Mar 19, 2024

Uh oh!

bors commented Mar 19, 2024

Uh oh!

bors commented Mar 20, 2024

Uh oh!

bors commented Mar 20, 2024

Uh oh!

rust-log-analyzer commented Mar 20, 2024

Uh oh!

workingjubilee commented Mar 22, 2024

Uh oh!

workingjubilee commented Mar 22, 2024

Uh oh!

Uh oh!

Gracefully handle AnonConst in diagnostic_hir_wf_check() #122370

Gracefully handle AnonConst in diagnostic_hir_wf_check() #122370

Uh oh!

Conversation

gurry commented Mar 12, 2024

Uh oh!

rustbot commented Mar 12, 2024

Uh oh!

davidtwco commented Mar 18, 2024

Uh oh!

bors commented Mar 18, 2024

Uh oh!

matthiaskrgr commented Mar 18, 2024

Uh oh!

This comment has been minimized.

workingjubilee commented Mar 18, 2024

Uh oh!

workingjubilee commented Mar 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gurry commented Mar 19, 2024

Uh oh!

workingjubilee commented Mar 19, 2024

Uh oh!

bors commented Mar 19, 2024

Uh oh!

bors commented Mar 20, 2024

Uh oh!

bors commented Mar 20, 2024

Uh oh!

rust-log-analyzer commented Mar 20, 2024

Uh oh!

workingjubilee commented Mar 22, 2024

Uh oh!

workingjubilee commented Mar 22, 2024

Uh oh!

Uh oh!

Gracefully handle `AnonConst` in `diagnostic_hir_wf_check()` #122370

Gracefully handle `AnonConst` in `diagnostic_hir_wf_check()` #122370

workingjubilee commented Mar 18, 2024 •

edited

Loading