Skip to content

Fill in HIR hash for associated opaque types #122517

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

petrochenkov
Copy link
Contributor

Fixes #122508

@rustbot
Copy link
Collaborator

rustbot commented Mar 14, 2024

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 14, 2024
@matthiaskrgr
Copy link
Member

@bors p=1

@oli-obk
Copy link
Contributor

oli-obk commented Mar 14, 2024

r? @oli-obk

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 14, 2024

📌 Commit ef5513f has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2024
@matthiaskrgr
Copy link
Member

@bors p=2

@matthiaskrgr
Copy link
Member

@bors p=15

@bors
Copy link
Collaborator

bors commented Mar 14, 2024

⌛ Testing commit ef5513f with merge 4bc1b3d...

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 14, 2024
Fill in HIR hash for associated opaque types

Fixes rust-lang#122508
@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling rustc_traits v0.0.0 (/checkout/compiler/rustc_traits)
   Compiling rustc_hir_typeck v0.0.0 (/checkout/compiler/rustc_hir_typeck)
[RUSTC-TIMING] rustc_resolve test:false 82.045
   Compiling rustc_mir_transform v0.0.0 (/checkout/compiler/rustc_mir_transform)
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
##[group]Clock drift check
  local time: Fri Mar 15 00:01:57 UTC 2024
  network time: Fri, 15 Mar 2024 00:01:57 GMT
##[endgroup]
##[endgroup]
Session terminated, killing shell... ...killed.
##[error]The operation was canceled.

@bors
Copy link
Collaborator

bors commented Mar 15, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 15, 2024
@lqd
Copy link
Member

lqd commented Mar 15, 2024

@bors retry The runner has received a shutdown signal

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2024
@bors
Copy link
Collaborator

bors commented Mar 15, 2024

⌛ Testing commit ef5513f with merge ee03c28...

@bors
Copy link
Collaborator

bors commented Mar 15, 2024

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing ee03c28 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 15, 2024
@bors bors merged commit ee03c28 into rust-lang:master Mar 15, 2024
@rustbot rustbot added this to the 1.78.0 milestone Mar 15, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ee03c28): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.2% [-2.2%, -2.2%] 1
Improvements ✅
(secondary)
-2.1% [-2.5%, -1.6%] 2
All ❌✅ (primary) -2.2% [-2.2%, -2.2%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.201s -> 669.125s (-0.31%)
Artifact size: 311.47 MiB -> 311.46 MiB (-0.00%)

@@ -642,23 +642,8 @@ impl<'a, 'hir> LoweringContext<'a, 'hir> {
let bodies = SortedMap::from_presorted_elements(bodies);

// Don't hash unless necessary, because it's expensive.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this comment is leftover but now belongs in hash_owner_nodes

@klensy
Copy link
Contributor

klensy commented Mar 15, 2024

#122396 | Try | 918ae71 | Finished | 3/15/2024, 2:42:19 PM | 1h 10m 14s |  
#122517 | Master | ee03c28 | Finished | 3/15/2024, 11:27:30 AM | 1h 41m 06s |  
#122053 | Try | 7a9b98b | Finished | 3/15/2024, 9:06:14 AM | 1h 10m 32s |  
#122511 | Master | c2901f5 | Finished | 3/15/2024, 6:58:22 AM | 1h 10m 40s |  
#122514 | Master | f4b771b | Finished | 3/15/2024, 5:45:13 AM | 1h 10m 24s

Strange fluke in time for perf run time for this pr (currently from https://perf.rust-lang.org/status.html)
cargo perf run was 35 mins instead of 5.

cargo-0.60.0 |   | 5m 03s | 35m 14s

@petrochenkov petrochenkov deleted the bodihash branch February 22, 2025 18:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: compiler/rustc_hir/src/stable_hash_impls.rs None with cargo build of async fn in trait
10 participants