Fix heading anchors in doc pages. #122693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
src/doc/rust.css
Outdated
| @@ -136,6 +136,28 @@ h1 a:link, h1 a:visited, h2 a:link, h2 a:visited, | |||
| h3 a:link, h3 a:visited, h4 a:link, h4 a:visited, | |||
| h5 a:link, h5 a:visited {color: black;} | |||
|
|
|||
| h1, h2, h3, h4, h5 { | |||
| /* This is needed to be able to position the doc-anchor. Ideally there | |||
| wold be a <div> around the whole document, but we don't have that. */ | |||
There was a problem hiding this comment.
Suggested change
| wold be a <div> around the whole document, but we don't have that. */ | |
| would be a <div> around the whole document, but we don't have that. */ |
|
Once typo fixed, r=me. We should really start to add ui tests for these pages as well... |
|
@bors r=GuillaumeGomez rollup |
bors
added
S-waiting-on-bors
ehuss
added
beta-nominated
|
Nominated for backport since it is a bit of an eyesore. I don't know if @Mark-Simulacrum wants to bother including this in the current stable candidate, though. |
notriddle
approved these changes
Mar 18, 2024
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Mar 18, 2024
…Gomez Fix heading anchors in doc pages. This fixes the heading anchors on the standalone doc pages (the index, releases, etc.) so that the § symbol is only shown when the user hovers over the heading. This was changed in rust-lang#117662, but this CSS was not updated.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 18, 2024
…Gomez Fix heading anchors in doc pages. This fixes the heading anchors on the standalone doc pages (the index, releases, etc.) so that the § symbol is only shown when the user hovers over the heading. This was changed in rust-lang#117662, but this CSS was not updated.
|
We link to nightly release notes from blog post so this will be fixed once it lands. @bors p=1 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 18, 2024
…iaskrgr Rollup of 12 pull requests Successful merges: - rust-lang#121258 (Reject overly generic assoc const binding types) - rust-lang#121823 (never patterns: suggest `!` patterns on non-exhaustive matches) - rust-lang#122060 (Stabilize `imported_main`) - rust-lang#122158 (Provide structured suggestion for `#![feature(foo)]`) - rust-lang#122642 (Improve wording of `Vec::swap_remove`) - rust-lang#122675 (core: document default attribute stabilization) - rust-lang#122687 (`NormalizesTo`: return nested goals to caller) - rust-lang#122691 (Fix ICE: `global_asm!()` Don't Panic When Unable to Evaluate Constant) - rust-lang#122693 (Fix heading anchors in doc pages.) - rust-lang#122699 (Fix a typo in the 1.77.0 relnotes) - rust-lang#122700 (Remove redundant files, rename base riscv32 file) - rust-lang#122701 (Detect allocator for box in `must_not_suspend` lint) r? `@ghost` `@rustbot` modify labels: rollup
It's not too important, just FYI the reason I nominated this is because it also affects the landing page like https://doc.rust-lang.org/beta/, which is also what users see if they run |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 18, 2024
Fix heading anchors in doc pages. This fixes the heading anchors on the standalone doc pages (the index, releases, etc.) so that the § symbol is only shown when the user hovers over the heading. This was changed in rust-lang#117662, but this CSS was not updated.
|
@bors retry yield rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 18, 2024
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#121258 (Reject overly generic assoc const binding types) - rust-lang#121823 (never patterns: suggest `!` patterns on non-exhaustive matches) - rust-lang#122060 (Stabilize `imported_main`) - rust-lang#122158 (Provide structured suggestion for `#![feature(foo)]`) - rust-lang#122642 (Improve wording of `Vec::swap_remove`) - rust-lang#122675 (core: document default attribute stabilization) - rust-lang#122687 (`NormalizesTo`: return nested goals to caller) - rust-lang#122693 (Fix heading anchors in doc pages.) - rust-lang#122699 (Fix a typo in the 1.77.0 relnotes) - rust-lang#122700 (Remove redundant files, rename base riscv32 file) - rust-lang#122701 (Detect allocator for box in `must_not_suspend` lint) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 18, 2024
Rollup merge of rust-lang#122693 - ehuss:rust-css-header, r=GuillaumeGomez Fix heading anchors in doc pages. This fixes the heading anchors on the standalone doc pages (the index, releases, etc.) so that the § symbol is only shown when the user hovers over the heading. This was changed in rust-lang#117662, but this CSS was not updated.
apiraino
added
the
T-rustdoc
Mark-Simulacrum
added
beta-accepted
Merged
cuviper
removed
the
beta-nominated
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 28, 2024
[beta] backports - Do not eat nested expressions' results in `MayContainYieldPoint` format args visitor rust-lang#122680 - Fix heading anchors in doc pages. rust-lang#122693 - Make `#[diagnostic::on_unimplemented]` format string parsing more robust rust-lang#122402 r? cuviper
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 29, 2024
[beta] backports - Do not eat nested expressions' results in `MayContainYieldPoint` format args visitor rust-lang#122680 - Fix heading anchors in doc pages. rust-lang#122693 - Make `#[diagnostic::on_unimplemented]` format string parsing more robust rust-lang#122402 - Update ninja on Windows rust-lang#123178 r? cuviper
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the heading anchors on the standalone doc pages (the index, releases, etc.) so that the § symbol is only shown when the user hovers over the heading. This was changed in #117662, but this CSS was not updated.