-
Notifications
You must be signed in to change notification settings - Fork 13.3k
add a couple more ice tests #122943
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
add a couple more ice tests #122943
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re=me with nits addressed
tests/ui/nll/ice-106874.rs
Outdated
//~^^ ERROR implementation of `Fn` is not general enough | ||
//~^^^ ERROR implementation of `FnOnce` is not general enough | ||
//~^^^^ ERROR implementation of `FnOnce` is not general enough | ||
//~^^^^^ ERROR implementation of `Fn` is not general enough | ||
//~^^^^^^ ERROR implementation of `FnOnce` is not general enough | ||
//~^^^^^^^ ERROR implementation of `Fn` is not general enough | ||
//~^^^^^^^^ ERROR implementation of `FnOnce` is not general enough | ||
//~^^^^^^^^^ ERROR higher-ranked subtype error | ||
//~^^^^^^^^^^ ERROR higher-ranked subtype error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//~^^ ERROR implementation of `Fn` is not general enough | |
//~^^^ ERROR implementation of `FnOnce` is not general enough | |
//~^^^^ ERROR implementation of `FnOnce` is not general enough | |
//~^^^^^ ERROR implementation of `Fn` is not general enough | |
//~^^^^^^ ERROR implementation of `FnOnce` is not general enough | |
//~^^^^^^^ ERROR implementation of `Fn` is not general enough | |
//~^^^^^^^^ ERROR implementation of `FnOnce` is not general enough | |
//~^^^^^^^^^ ERROR higher-ranked subtype error | |
//~^^^^^^^^^^ ERROR higher-ranked subtype error | |
//~| ERROR implementation of `Fn` is not general enough | |
//~| ERROR implementation of `FnOnce` is not general enough | |
//~| ERROR implementation of `FnOnce` is not general enough | |
//~| ERROR implementation of `Fn` is not general enough | |
//~| ERROR implementation of `FnOnce` is not general enough | |
//~| ERROR implementation of `Fn` is not general enough | |
//~| ERROR implementation of `FnOnce` is not general enough | |
//~| ERROR higher-ranked subtype error | |
//~| ERROR higher-ranked subtype error |
//~^^ ERROR pointers cannot be reliably compared during const eval | ||
//~^^^ WARN this was previously accepted by the compiler but is being phased out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//~^^ ERROR pointers cannot be reliably compared during const eval | |
//~^^^ WARN this was previously accepted by the compiler but is being phased out | |
//~| ERROR pointers cannot be reliably compared during const eval | |
//~| WARN this was previously accepted by the compiler but is being phased out |
✌️ @matthiaskrgr, you can now approve this pull request! If @fmease told you to " |
Thanks a lot, Matthias, for attacking
E-needs-test
|
I wrote a small crate that adds the |
@bors r=fmease |
That's really cool! :) This notwithstanding, the reason we should use Should be easy to make your tool use |
…xxxx, r=fmease add a couple more ice tests Fixes rust-lang#104779 Fixes rust-lang#106423 Fixes rust-lang#106444 Fixes rust-lang#101852 Fixes rust-lang#106874 Fixes rust-lang#105047 Fixes rust-lang#107228 Fixes rust-lang#99945
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#122379 (transmute: caution against int2ptr transmutation) - rust-lang#122895 (add some ice tests 5xxxx to 9xxxx) - rust-lang#122907 (Uniquify `ReError` on input mode in canonicalizer) - rust-lang#122942 (Add test in higher ranked subtype) - rust-lang#122943 (add a couple more ice tests) - rust-lang#122952 (Miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
…xxxx, r=fmease add a couple more ice tests Fixes rust-lang#104779 Fixes rust-lang#106423 Fixes rust-lang#106444 Fixes rust-lang#101852 Fixes rust-lang#106874 Fixes rust-lang#105047 Fixes rust-lang#107228 Fixes rust-lang#99945
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#116016 (Soft-destabilize `RustcEncodable` & `RustcDecodable`, remove from prelude in next edition) - rust-lang#121281 (regression test for rust-lang#103626) - rust-lang#122168 (Fix validation on substituted callee bodies in MIR inliner) - rust-lang#122217 (Handle str literals written with `'` lexed as lifetime) - rust-lang#122379 (transmute: caution against int2ptr transmutation) - rust-lang#122907 (Uniquify `ReError` on input mode in canonicalizer) - rust-lang#122942 (Add test in higher ranked subtype) - rust-lang#122943 (add a couple more ice tests) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#116016 (Soft-destabilize `RustcEncodable` & `RustcDecodable`, remove from prelude in next edition) - rust-lang#121281 (regression test for rust-lang#103626) - rust-lang#122168 (Fix validation on substituted callee bodies in MIR inliner) - rust-lang#122217 (Handle str literals written with `'` lexed as lifetime) - rust-lang#122379 (transmute: caution against int2ptr transmutation) - rust-lang#122907 (Uniquify `ReError` on input mode in canonicalizer) - rust-lang#122942 (Add test in higher ranked subtype) - rust-lang#122943 (add a couple more ice tests) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#121281 (regression test for rust-lang#103626) - rust-lang#122168 (Fix validation on substituted callee bodies in MIR inliner) - rust-lang#122217 (Handle str literals written with `'` lexed as lifetime) - rust-lang#122379 (transmute: caution against int2ptr transmutation) - rust-lang#122840 (`rustdoc --test`: Prevent reaching the maximum size of command-line by using files for arguments if there are too many) - rust-lang#122907 (Uniquify `ReError` on input mode in canonicalizer) - rust-lang#122942 (Add test in higher ranked subtype) - rust-lang#122943 (add a couple more ice tests) - rust-lang#122963 (core/panicking: fix outdated comment) r? `@ghost` `@rustbot` modify labels: rollup
…xxxx, r=fmease add a couple more ice tests Fixes rust-lang#104779 Fixes rust-lang#106423 Fixes rust-lang#106444 Fixes rust-lang#101852 Fixes rust-lang#106874 Fixes rust-lang#105047 Fixes rust-lang#107228 Fixes rust-lang#99945
Rollup merge of rust-lang#122943 - matthiaskrgr:ice-tests-9xxxx-to-12xxxx, r=fmease add a couple more ice tests Fixes rust-lang#104779 Fixes rust-lang#106423 Fixes rust-lang#106444 Fixes rust-lang#101852 Fixes rust-lang#106874 Fixes rust-lang#105047 Fixes rust-lang#107228 Fixes rust-lang#99945
…xxxx, r=fmease add a couple more ice tests Fixes rust-lang#104779 Fixes rust-lang#106423 Fixes rust-lang#106444 Fixes rust-lang#101852 Fixes rust-lang#106874 Fixes rust-lang#105047 Fixes rust-lang#107228 Fixes rust-lang#99945
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#121281 (regression test for rust-lang#103626) - rust-lang#122168 (Fix validation on substituted callee bodies in MIR inliner) - rust-lang#122217 (Handle str literals written with `'` lexed as lifetime) - rust-lang#122379 (transmute: caution against int2ptr transmutation) - rust-lang#122840 (`rustdoc --test`: Prevent reaching the maximum size of command-line by using files for arguments if there are too many) - rust-lang#122907 (Uniquify `ReError` on input mode in canonicalizer) - rust-lang#122942 (Add test in higher ranked subtype) - rust-lang#122943 (add a couple more ice tests) - rust-lang#122963 (core/panicking: fix outdated comment) r? `@ghost` `@rustbot` modify labels: rollup
Fixes #104779
Fixes #106423
Fixes #106444
Fixes #101852
Fixes #106874
Fixes #105047
Fixes #107228
Fixes #99945