Skip to content

Restore the test checks for wider_reduce_into_iter #123167

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

dianqk
Copy link
Member

@dianqk dianqk commented Mar 28, 2024

The current minimum support is for LLVM 17. Context: #116018 (comment).

r? scottmcm

The current minimum support is for LLVM 17.
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 28, 2024
@scottmcm
Copy link
Member

Thanks for circling back to this!

@bors r+ rollup=iffy (probably fine, but whenever there's codegen tests involved things sometimes go weird)

@bors
Copy link
Collaborator

bors commented Mar 28, 2024

📌 Commit ec359f7 has been approved by scottmcm

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2024
@bors
Copy link
Collaborator

bors commented Mar 28, 2024

⌛ Testing commit ec359f7 with merge 929bcee...

@bors
Copy link
Collaborator

bors commented Mar 28, 2024

☀️ Test successful - checks-actions
Approved by: scottmcm
Pushing 929bcee to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Mar 28, 2024

☀️ Test successful - checks-actions
Approved by: scottmcm
Pushing 929bcee to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 28, 2024
@bors bors merged commit 929bcee into rust-lang:master Mar 28, 2024
@rustbot rustbot added this to the 1.79.0 milestone Mar 28, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (929bcee): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.5% [0.5%, 0.6%] 4
Regressions ❌
(secondary)
0.4% [0.3%, 0.5%] 7
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.5% [0.5%, 0.6%] 4

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.4% [-2.4%, -2.4%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.4% [-2.4%, -2.4%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.68s -> 668.937s (-0.11%)
Artifact size: 315.70 MiB -> 315.71 MiB (0.00%)

@rustbot rustbot added the perf-regression Performance regression. label Mar 28, 2024
@scottmcm
Copy link
Member

Clearly noise; the PR only changed tests/codegen.
@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Mar 28, 2024
@dianqk dianqk deleted the test-simd-wide-sum branch March 29, 2024 01:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants