Follow std library convention and return Option for to_ascii() and into_ascii() instead of failing #12320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use explicit unwrap() where needed. Basically rename: * to_ascii_opt -> to_ascii * into_ascii_opt -> into_ascii and get rid of the version which uses fail!
| /// Take ownership and cast to an ascii vector. Return None on non-ASCII input. | ||
| #[inline] | ||
| fn into_ascii_opt(self) -> Option<~[Ascii]> { |
There was a problem hiding this comment.
Will users want the value of self back if the conversion fails? It may be worth changing the return type of this to Result<~[Ascii], Self>.
Return Err(self) from into_ascii() in case of error, so the original value is not lost.
|
I changed into_ascii() to return a Result as you suggested. |
|
Fixed by eca39b0 |
| @@ -529,21 +513,21 @@ mod tests { | |||
| #[test] | |||
| fn test_ascii_vec() { | |||
| let test = &[40u8, 32u8, 59u8]; | |||
| assert_eq!(test.to_ascii(), v2ascii!([40, 32, 59])); | |||
| assert_eq!("( ;".to_ascii(), v2ascii!([40, 32, 59])); | |||
| assert_eq!(test.to_ascii(), Some(v2ascii!([40, 32, 59]))); | |||
There was a problem hiding this comment.
So assert_eq!(test.to_ascii(), Some(v2ascii!(&[40, 32, 59]))); instead?
|
Closing due to inactivity, but feel free to reopen with a rebase! |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
Hide closure ret hints if ret type is specified Fixes rust-lang#12319
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 26, 2024
…t-lang#13830) fix rust-lang#12320 When there're multiple attributes, clippy suggests leaving an extra comma and it makes an error. changelog: [`must_use_unit`]: No longer make incorrect suggestions when multiple attributes present.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return an Option for to_ascii() and into_ascii() functions. Remove to_ascii_opt() and into_ascii_opt().