-
Notifications
You must be signed in to change notification settings - Fork 13.3k
[experiment] Set never type fallback = !
#123482
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[experiment] Set never type fallback = !
#123482
Conversation
The job Click to see the possible cause of the failure (guessed by this bot)
|
@bors try |
…self, r=<try> [experiment] Set never type fallback = `!` r? ghost cc `@traviscross`
☀️ Try build successful - checks-actions |
@craterbot run start=master#385fa9d845dd326c6bbfd58c22244215e431948a end=try#2d84f2737f3bd9ebfcb07f75aa198d6cf7c715d2 mode=check-only name=never-type-fallback-to-never list:https://crater-reports.s3.amazonaws.com/no-never-type-fallback/retry-regressed-list.txt (using #122955's regressions as the crate list, since this can only break things that #122955 broke) |
🚨 Error: failed to parse the command 🆘 If you have any trouble with Crater please ping |
@craterbot run start=master#385fa9d845dd326c6bbfd58c22244215e431948a end=try#2d84f2737f3bd9ebfcb07f75aa198d6cf7c715d2 mode=check-only name=never-type-fallback-to-never crates=https://crater-reports.s3.amazonaws.com/no-never-type-fallback/retry-regressed-list.txt (using #122955 regressions as the crate list, since this can only break things that #122955 broke) |
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🎉 Experiment
|
…, r=compiler-errors Correctly change type when adding adjustments on top of `NeverToAny` I'm concerned that the check only caught the problem with `fallback = !`, because at least MIR contained `<() as PartialEq>::eq(move _5, move _7)` where `_5: ()`. I rediscovered the issue when looking at rust-lang#123482's crater run. r? compiler-errors Fixes rust-lang#120600
…, r=compiler-errors Correctly change type when adding adjustments on top of `NeverToAny` I'm concerned that the check only caught the problem with `fallback = !`, because at least MIR contained `<() as PartialEq>::eq(move _5, move _7)` where `_5: ()`. I rediscovered the issue when looking at rust-lang#123482's crater run. r? compiler-errors Fixes rust-lang#120600
…, r=compiler-errors Correctly change type when adding adjustments on top of `NeverToAny` I'm concerned that the check only caught the problem with `fallback = !`, because at least MIR contained `<() as PartialEq>::eq(move _5, move _7)` where `_5: ()`. I rediscovered the issue when looking at rust-lang#123482's crater run. r? compiler-errors Fixes rust-lang#120600
…, r=compiler-errors Correctly change type when adding adjustments on top of `NeverToAny` I'm concerned that the check only caught the problem with `fallback = !`, because at least MIR contained `<() as PartialEq>::eq(move _5, move _7)` where `_5: ()`. I rediscovered the issue when looking at rust-lang#123482's crater run. r? compiler-errors Fixes rust-lang#120600
…, r=compiler-errors Correctly change type when adding adjustments on top of `NeverToAny` I'm concerned that the check only caught the problem with `fallback = !`, because at least MIR contained `<() as PartialEq>::eq(move _5, move _7)` where `_5: ()`. I rediscovered the issue when looking at rust-lang#123482's crater run. r? compiler-errors Fixes rust-lang#120600
Rollup merge of rust-lang#123571 - WaffleLapkin:properly-adjust-never, r=compiler-errors Correctly change type when adding adjustments on top of `NeverToAny` I'm concerned that the check only caught the problem with `fallback = !`, because at least MIR contained `<() as PartialEq>::eq(move _5, move _7)` where `_5: ()`. I rediscovered the issue when looking at rust-lang#123482's crater run. r? compiler-errors Fixes rust-lang#120600
r? ghost
cc @traviscross
Tracking:
!
fall back to!
#123748