async closure coroutine by move body MirPass refactoring #123668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
rustbot
added
the
S-waiting-on-review
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustbot
added
the
T-compiler
This comment was marked as resolved.
This comment was marked as resolved.
| @@ -233,6 +233,7 @@ impl<'tcx> MirPass<'tcx> for ByMoveBody { | |||
| let mut by_move_body = body.clone(); | |||
| MakeByMoveBody { tcx, field_remapping, by_move_coroutine_ty }.visit_body(&mut by_move_body); | |||
| dump_mir(tcx, false, "coroutine_by_move", &0, &by_move_body, |_, _| Ok(())); | |||
| // FIXME: use query feeding to generate the body right here and then only store the ``DefId` of the new body.` | |||
|
So this is gonna conflict w/ 8af94ce, where I pulled this out into a helper. I could adapt that to iterate over the child rather than the parent, but it doesn't seem to be much cleaner at that point. |
|
I guess it's fine though, and I can just rebase on top of this. r=me with the backticks fixed |
|
@rustbot author |
rustbot
added
S-waiting-on-author
…nt captures to child captures
oli-obk
force-pushed
the
by_move_body_golfing
branch
from
6ab363c to
e14e795
Compare
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 10, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#121884 (Port exit-code run-make test to use rust) - rust-lang#122200 (Unconditionally show update nightly hint on ICE) - rust-lang#123568 (Clean up tests/ui by removing `does-nothing.rs`) - rust-lang#123609 (Don't use bytepos offsets when computing semicolon span for removal) - rust-lang#123612 (Set target-abi module flag for RISC-V targets) - rust-lang#123633 (Store all args in the unsupported Command implementation) - rust-lang#123668 (async closure coroutine by move body MirPass refactoring) Failed merges: - rust-lang#123701 (Only assert for child/parent projection compatibility AFTER checking that theyre coming from the same place) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 10, 2024
Rollup merge of rust-lang#123668 - oli-obk:by_move_body_golfing, r=compiler-errors async closure coroutine by move body MirPass refactoring Unsure about the last commit, but I think the other changes help in simplifying the control flow
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure about the last commit, but I think the other changes help in simplifying the control flow