Taint const qualifs if a static is referenced that didn't pass wfcheck #123675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
rustbot
added
S-waiting-on-review
jieyouxu
reviewed
Apr 9, 2024
Comment on lines
334
to
335
| if let Some(def_id) = def_id.as_local() { | ||
| if let Err(guar) = self.tcx.at(span).check_well_formed(hir::OwnerId { def_id }) { |
|
@rustbot author |
rustbot
added
S-waiting-on-author
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
|
@bors r- |
bors
added
S-waiting-on-author
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 17, 2024
…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#123673 (Don't ICE for kind mismatches during error rendering) - rust-lang#123675 (Taint const qualifs if a static is referenced that didn't pass wfcheck) - rust-lang#123975 (Port the 2 `rust-lld` run-make tests to `rmake`) - rust-lang#124000 (Use `/* value */` as a placeholder) - rust-lang#124013 (Box::into_raw: make Miri understand that this is a box-to-raw cast) - rust-lang#124027 (Prefer identity equality over equating types during coercion.) - rust-lang#124036 (Remove `default_hidden_visibility: false` from wasm targets) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 17, 2024
Rollup merge of rust-lang#123675 - oli-obk:static_wf_ice, r=compiler-errors Taint const qualifs if a static is referenced that didn't pass wfcheck It is correct to only check the signature here, as the ICE is caused by `USE_WITH_ERROR` trying to allocate memory to store the result of `WITH_ERROR` before evaluating it. fixes rust-lang#123153
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is correct to only check the signature here, as the ICE is caused by
USE_WITH_ERRORtrying to allocate memory to store the result ofWITH_ERRORbefore evaluating it.fixes #123153