Replace document.write with document.head.insertAdjacent
#123784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
the8472
reviewed
Apr 11, 2024
GuillaumeGomez
force-pushed
the
replace-document-write
branch
from
071a15b to
4fbb796
Compare
notriddle
reviewed
Apr 11, 2024
GuillaumeGomez
force-pushed
the
replace-document-write
branch
from
4fbb796 to
7b6f3ee
Compare
GuillaumeGomez
changed the title
document.write with document.head.innerHTMLdocument.write with document.head.insertAdjacent
the8472
reviewed
Apr 11, 2024
GuillaumeGomez
force-pushed
the
replace-document-write
branch
from
7b6f3ee to
78184df
Compare
GuillaumeGomez
force-pushed
the
replace-document-write
branch
from
78184df to
510bfc2
Compare
the8472
reviewed
Apr 11, 2024
|
All solved. :) |
|
Okay, let's do that then. @bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 11, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#122882 (Avoid a panic in `set_output_capture` in the default panic handler) - rust-lang#123523 (Account for trait/impl difference when suggesting changing argument from ref to mut ref) - rust-lang#123744 (Silence `unused_imports` for redundant imports) - rust-lang#123784 (Replace `document.write` with `document.head.insertAdjacent`) - rust-lang#123798 (Avoid invalid socket address in length calculation) - rust-lang#123804 (Stop using `HirId` for fn-like parents since closures are not `OwnerNode`s) - rust-lang#123806 (Panic on overflow in `BorrowedCursor::advance`) - rust-lang#123820 (Add my former address to .mailmap) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 12, 2024
Rollup merge of rust-lang#123784 - GuillaumeGomez:replace-document-write, r=notriddle Replace `document.write` with `document.head.insertAdjacent` From [this comment](https://github.com/rust-lang/rust/pull/123706/files#r1559864981), using `document.write` is strongly discouraged (explained on [MDN](https://developer.mozilla.org/en-US/docs/Web/API/Document/write)). I think in this case it was mostly ok but better be on the safe side. r? `@notriddle`
|
Luckily, not that big of a regression: https://perf.rust-lang.org/compare.html?start=616a8f85f153033d798b583c0ad0431924a738b0&end=a07f3eb43acc5df851e15176c7081a900a30a4d7&stat=size%3Adoc_bytes |
|
That's what I kept in mind when writing it. Glad we still achieved such a big size improvement thanks to you. :) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From this comment, using
document.writeis strongly discouraged (explained on MDN).I think in this case it was mostly ok but better be on the safe side.
r? @notriddle