Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Disable two debuginfo tests failing under the future GDB 15 release #123963

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

lqd
Copy link
Member

@lqd lqd commented Apr 15, 2024

As seen in #123960, it seems two of our debuginfo tests started failing on gdb 15, which is also already in use in the x86_64-gnu-llvm-18 builder: CI will randomly start to fail whenever this cached docker image expires.

This PR disables the following two tests under gdb 15+, to prevent future CI failures.

  • tests/debuginfo/include_string.rs
  • tests/debuginfo/vec-slices.rs

This seems very much related to https://sourceware.org/bugzilla/show_bug.cgi?id=30330 and https://sourceware.org/bugzilla/show_bug.cgi?id=31517 -- and I just now saw #122751 as well, where one of these bugzilla issues and one of the two test failures here was previously mentioned.

I don't know whether these are unexpected gdb changes, or if we need to change our tests as it seems some of the gdb changes are definitely intentional, so I'll just cc @rust-lang/wg-debugging and @tromey.

(In the same area, tests/debuginfo/unsized.rs was previously disabled due to https://sourceware.org/bugzilla/show_bug.cgi?id=30330. This issue has been fixed but I don't believe our test passes, so it's in the same boat as the 2 above regarding whether this test is expected to work or needs changes as well)

r? wg-debugging

I've confirmed this is enough to have CI pass on gdb 15 with the llvm 18 builder.

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Apr 15, 2024
it seems gdb 15 regresses some of our debuginfo tests. disable them
temporarily so that CI doesn't randomly start failing soon.
@Kobzol
Copy link
Contributor

Kobzol commented Apr 16, 2024

The GDB 15 failure is starting to break our CI: #123468 (comment).

@Kobzol
Copy link
Contributor

Kobzol commented Apr 16, 2024

I'm going to go ahead and approve this to unblock CI, as it is a hotfix.

@bors r+ p=10

@bors
Copy link
Contributor

bors commented Apr 16, 2024

📌 Commit 6e19f82 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2024
@bors
Copy link
Contributor

bors commented Apr 16, 2024

⌛ Testing commit 6e19f82 with merge ad18fe0...

@bors
Copy link
Contributor

bors commented Apr 16, 2024

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing ad18fe0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 16, 2024
@bors bors merged commit ad18fe0 into rust-lang:master Apr 16, 2024
12 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 16, 2024
@lqd lqd deleted the gdb15-failures branch April 16, 2024 12:26
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ad18fe0): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
4.1% [4.1%, 4.1%] 1
Regressions ❌
(secondary)
2.3% [2.3%, 2.3%] 1
Improvements ✅
(primary)
-0.6% [-0.6%, -0.6%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.8% [-0.6%, 4.1%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.8% [-0.8%, -0.8%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 678.471s -> 678.547s (0.01%)
Artifact size: 316.03 MiB -> 316.00 MiB (-0.01%)

@lqd lqd mentioned this pull request Apr 19, 2024
@cuviper
Copy link
Member

cuviper commented Apr 19, 2024

I'm unilaterally backporting this in #124139 to unblock it.

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 19, 2024
@cuviper cuviper modified the milestones: 1.79.0, 1.78.0 Apr 19, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 19, 2024
[beta] backports

- Silence `unused_imports` lint for redundant imports rust-lang#123744
- Call the panic hook for non-unwind panics in proc-macros rust-lang#123825
- rustdoc: check redundant explicit links with correct itemid rust-lang#123905
- disable two debuginfo tests under gdb 15 rust-lang#123963

r? cuviper
@michaelwoerister
Copy link
Member

From the linked issues it looks like the python pretty printers need to be updated, but I haven't had time yet to investigate in more detail.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants