Skip to content

Miri subtree update #124430

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 8 commits into from
Apr 27, 2024
Merged

Miri subtree update #124430

merged 8 commits into from
Apr 27, 2024

Conversation

RalfJung
Copy link
Member

r? @ghost

The Miri Cronjob Bot and others added 8 commits April 26, 2024 04:58
add smoke tests for basic PathBuf interactions

I wrote these while debugging [this](https://github.com/rust-lang/miri-test-libstd/actions/runs/8849912635/job/24302962983); it turns out the issue is [more complicated](rust-lang#124409) but these tests still seemed worth keeping.
env: split up Windows and Unix environment variable handling

On Windows, manage them entirely outside the AM state; this also means we no longer report any data races for environment variable memory.

Fixes rust-lang#124411
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 27, 2024
@rustbot
Copy link
Collaborator

rustbot commented Apr 27, 2024

The Miri subtree was changed

cc @rust-lang/miri

@RalfJung
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 27, 2024

📌 Commit 3a74fae has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2024
@bors
Copy link
Collaborator

bors commented Apr 27, 2024

⌛ Testing commit 3a74fae with merge 261823e...

@bors
Copy link
Collaborator

bors commented Apr 27, 2024

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 261823e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 27, 2024
@bors bors merged commit 261823e into rust-lang:master Apr 27, 2024
@rustbot rustbot added this to the 1.79.0 milestone Apr 27, 2024
@RalfJung RalfJung deleted the miri branch April 27, 2024 11:58
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (261823e): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.0% [3.0%, 3.0%] 1
Regressions ❌
(secondary)
5.8% [5.8%, 5.8%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.0% [3.0%, 3.0%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
6.4% [5.9%, 6.9%] 2
Improvements ✅
(primary)
-0.9% [-0.9%, -0.9%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.9% [-0.9%, -0.9%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.621s -> 674.042s (0.21%)
Artifact size: 315.96 MiB -> 315.92 MiB (-0.02%)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants