Skip to content

Relax A: Clone bound for rc::Weak::into_raw_and_alloc #124432

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

zetanumbers
Copy link
Contributor

Makes this method to behave the same way as Box::into_raw_with_allocator and Vec::into_raw_parts_with_alloc.

I have also noticed the inconsistent presence and naming, should probably be addressed in the future.

@rustbot
Copy link
Collaborator

rustbot commented Apr 27, 2024

r? @Nilstrieb

rustbot has assigned @Nilstrieb.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 27, 2024
@rust-log-analyzer

This comment has been minimized.

@zetanumbers zetanumbers force-pushed the non_copy_into_raw_with_alloc branch from 7993163 to 255a1e9 Compare April 27, 2024 09:21
@Noratrieb
Copy link
Member

This brings an unstable API in line with the other variants of it, being an obvious improvement relaxing a bound that didn't make sense in the first place, so I'm approving this without libs-api input.
@bors r+

@bors
Copy link
Collaborator

bors commented Apr 27, 2024

📌 Commit 255a1e9 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2024
@bors
Copy link
Collaborator

bors commented Apr 27, 2024

⌛ Testing commit 255a1e9 with merge 61a1dbd...

@bors
Copy link
Collaborator

bors commented Apr 27, 2024

☀️ Test successful - checks-actions
Approved by: Nilstrieb
Pushing 61a1dbd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 27, 2024
@bors bors merged commit 61a1dbd into rust-lang:master Apr 27, 2024
11 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 27, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (61a1dbd): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-4.8% [-4.8%, -4.8%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -4.8% [-4.8%, -4.8%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-5.7% [-6.2%, -5.4%] 3
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 674.042s -> 672.072s (-0.29%)
Artifact size: 315.92 MiB -> 315.90 MiB (-0.00%)

@zetanumbers zetanumbers deleted the non_copy_into_raw_with_alloc branch April 27, 2024 17:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants