add a reference link to the comment of the "cc" and "cmake". #124573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: onur-ozkan <work@onurozkan.dev>
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 4, 2024
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#124501 (add support to override lldb binary path for ./x test) - rust-lang#124573 (add a reference link to the comment of the "cc" and "cmake".) - rust-lang#124663 (Enable reusing CI Docker cache when running CI images locally) - rust-lang#124690 (Only consider ambiguous goals when finding best obligation for ambiguities) - rust-lang#124713 (Update Cargo specific diagnostics in check-cfg) - rust-lang#124717 (Implement `do_not_recommend` in the new solver) - rust-lang#124718 (Record impl args in the proof tree) - rust-lang#124720 (interpret: Drop: always evaluate place) - rust-lang#124721 (library/std: Fix build for NetBSD targets with 32-bit `c_long`) - rust-lang#124723 (Use correct Hermit links in The `rustc` Book) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 4, 2024
Rollup merge of rust-lang#124573 - onur-ozkan:update-dep-comment, r=Mark-Simulacrum add a reference link to the comment of the "cc" and "cmake". Having a reference link provides more context for the problems of bumping cc and cmake.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a reference link provides more context for the problems of bumping cc and cmake.