generalize hr alias: avoid unconstrainable infer vars #124827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
changes to the core type system |
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
generalize-incomplete
branch
from
a25d6e6 to
e9f3a59
Compare
| && !self.infcx.intercrate | ||
| && self.in_alias | ||
| { | ||
| variable_table.union(vid, new_var_id) |
There was a problem hiding this comment.
Suggested change
| variable_table.union(vid, new_var_id) | |
| variable_table.union(vid, new_var_id); |
rust-cloud-vms
bot
force-pushed
the
generalize-incomplete
branch
from
e9f3a59 to
7c9494b
Compare
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
rustbot
added
the
WG-trait-system-refactor
lcnr
changed the title
rust-cloud-vms
bot
force-pushed
the
generalize-incomplete
branch
from
7c9494b to
690d5aa
Compare
compiler-errors
approved these changes
May 7, 2024
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 7, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#124738 (rustdoc: dedup search form HTML) - rust-lang#124827 (generalize hr alias: avoid unconstrainable infer vars) - rust-lang#124832 (narrow down visibilities in `rustc_parse::lexer`) - rust-lang#124842 (replace another Option<Span> by DUMMY_SP) - rust-lang#124846 (Don't ICE when we cannot eval a const to a valtree in the new solver) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 7, 2024
Rollup merge of rust-lang#124827 - lcnr:generalize-incomplete, r=compiler-errors generalize hr alias: avoid unconstrainable infer vars fixes rust-lang/trait-system-refactor-initiative#108 see inline comments for more details r? `@compiler-errors` cc `@BoxyUwU`
This was referenced May 7, 2024
|
homu still thinks this is in queue for some reason, so trying to talk some reason into it: @bors r- |
bors
added
S-waiting-on-author
This was referenced May 13, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes rust-lang/trait-system-refactor-initiative#108
see inline comments for more details
r? @compiler-errors cc @BoxyUwU