Rollup of 7 pull requests

[matthiaskrgr]

Successful merges:

• Add benchmarks for impl Debug for str #124551 (Add benchmarks for impl Debug for str)
• Remove #[macro_use] extern crate rustc middle from numerous crates #124914 (Remove #[macro_use] extern crate rustc middle from numerous crates)
• rustc_target cleanups #124915 (rustc_target cleanups)
• Eliminate some FIXME(lcnr) comments #124918 (Eliminate some FIXME(lcnr) comments)
• opt-dist: use xz2 instead of xz crate #124927 (opt-dist: use xz2 instead of xz crate)
• analyse visitor: build proof tree in probe #124936 (analyse visitor: build proof tree in probe)
• always use GenericArgsRef #124943 (always use GenericArgsRef)

Failed merges:

• Use fewer origins when creating type variables. #124955 (Use fewer origins when creating type variables.)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[matthiaskrgr]

@bors r+ rollup=never p=8

[bors]

📌 Commit 3439a87 has been approved by matthiaskrgr

It is now in the queue for this repository.

[rust-log-analyzer]

The job x86_64-gnu-llvm-17 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

#16 exporting to docker image format
#16 sending tarball 29.1s done
#16 DONE 41.9s
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-17]
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-17', '--enable-llvm-link-shared', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'change-id=99999999', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-17/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.thin-lto-import-instr-limit := 10
configure: change-id            := 99999999
---
   Compiling rustc_smir v0.0.0 (/checkout/compiler/rustc_smir)
error: cannot find macro `bug` in this scope
  --> compiler/rustc_infer/src/errors/note_and_explain.rs:73:17
   |
73 |                 bug!("unexpected region for DescriptionCtx: {:?}", region);
   |
help: consider importing this macro
   |
1  + use rustc_middle::bug;
1  + use rustc_middle::bug;
   |

error[E0308]: `match` arms have incompatible types
  --> compiler/rustc_infer/src/errors/note_and_explain.rs:73:17
   |
19 |           let (span, kind, arg) = match *region {
   |                                   ------------- `match` arms have incompatible types
...
29 | /                 if br.has_name() {
30 | |                     (Some(span), "as_defined", br.name.to_string())
31 | |                 } else {
32 | |                     (Some(span), "as_defined_anon", String::new())
33 | |                 }
   | |_________________- this is found to be of type `(std::option::Option<rustc_span::Span>, &str, std::string::String)`
...
36 | /                 if !fr.bound_region.is_named()
37 | |                     && let Some((ty, _)) = find_anon_type(tcx, region, &fr.bound_region)
38 | |                 {
39 | |                     (Some(ty.span), "defined_here", String::new())
64 | |                     }
65 | |                 }
65 | |                 }
   | |_________________- this is found to be of type `(std::option::Option<rustc_span::Span>, &str, std::string::String)`
...
68 |               ty::ReStatic => (alt_span, "restatic", String::new()),
   |                               ------------------------------------- this is found to be of type `(std::option::Option<rustc_span::Span>, &str, std::string::String)`
...
73 |                   bug!("unexpected region for DescriptionCtx: {:?}", region);
   |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `(Option<Span>, &str, String)`, found `()`
   |
   = note:  expected tuple `(std::option::Option<rustc_span::Span>, &str, std::string::String)`

For more information about this error, try `rustc --explain E0308`.
error: could not compile `rustc_infer` (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...

[bors]

⌛ Testing commit 3439a87 with merge ad31ee3...

[rust-log-analyzer]

The job armhf-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   Compiling rustc_mir_dataflow v0.0.0 (/checkout/compiler/rustc_mir_dataflow)
error: cannot find macro `bug` in this scope
  --> compiler/rustc_infer/src/errors/note_and_explain.rs:73:17
   |
73 |                 bug!("unexpected region for DescriptionCtx: {:?}", region);
   |
help: consider importing this macro
   |
1  + use rustc_middle::bug;
1  + use rustc_middle::bug;
   |

[RUSTC-TIMING] nix test:false 3.011
   Compiling rustc_metadata v0.0.0 (/checkout/compiler/rustc_metadata)
error[E0308]: `match` arms have incompatible types
  --> compiler/rustc_infer/src/errors/note_and_explain.rs:73:17
   |
19 |           let (span, kind, arg) = match *region {
   |                                   ------------- `match` arms have incompatible types
...
29 | /                 if br.has_name() {
30 | |                     (Some(span), "as_defined", br.name.to_string())
31 | |                 } else {
32 | |                     (Some(span), "as_defined_anon", String::new())
33 | |                 }
   | |_________________- this is found to be of type `(std::option::Option<rustc_span::Span>, &str, std::string::String)`
...
36 | /                 if !fr.bound_region.is_named()
37 | |                     && let Some((ty, _)) = find_anon_type(tcx, region, &fr.bound_region)
38 | |                 {
39 | |                     (Some(ty.span), "defined_here", String::new())
64 | |                     }
65 | |                 }
65 | |                 }
   | |_________________- this is found to be of type `(std::option::Option<rustc_span::Span>, &str, std::string::String)`
...
68 |               ty::ReStatic => (alt_span, "restatic", String::new()),
   |                               ------------------------------------- this is found to be of type `(std::option::Option<rustc_span::Span>, &str, std::string::String)`
...
73 |                   bug!("unexpected region for DescriptionCtx: {:?}", region);
   |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `(Option<Span>, &str, String)`, found `()`
   |
   = note:  expected tuple `(std::option::Option<rustc_span::Span>, &str, std::string::String)`

[RUSTC-TIMING] tracing_subscriber test:false 8.019
   Compiling rustc_pattern_analysis v0.0.0 (/checkout/compiler/rustc_pattern_analysis)
For more information about this error, try `rustc --explain E0308`.

[bors]

💔 Test failed - checks-actions