Skip to content

crashes: increment the number of tracked ones #125539

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
May 28, 2024
Merged

Conversation

matthiaskrgr
Copy link
Member

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 25, 2024
@matthiaskrgr
Copy link
Member Author

@bors rollup=iffy

@jieyouxu
Copy link
Member

Thanks! @bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 26, 2024

📌 Commit ce67768 has been approved by jieyouxu

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented May 26, 2024

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 26, 2024
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request May 26, 2024
crashes: increment the number of tracked ones

r? `@jieyouxu`
bors added a commit to rust-lang-ci/rust that referenced this pull request May 26, 2024
…kingjubilee

Rollup of 10 pull requests

Successful merges:

 - rust-lang#125046 (Only allow immutable statics with #[linkage])
 - rust-lang#125466 (Don't continue probing for method if in suggestion and autoderef hits ambiguity)
 - rust-lang#125469 (Don't skip out of inner const when looking for body for suggestion)
 - rust-lang#125530 (cleanup dependence of `ExtCtxt` in transcribe when macro expansion)
 - rust-lang#125535 (clean-up: remove deprecated field `dist.missing-tools`)
 - rust-lang#125539 (crashes: increment the number of tracked ones)
 - rust-lang#125544 (Also mention my-self for other check-cfg docs changes)
 - rust-lang#125559 (Simplify the `unchecked_sh[lr]` ub-checks a bit)
 - rust-lang#125566 (Notify T-rustdoc for beta-accepted and stable-accepted too)
 - rust-lang#125582 (Avoid a `FieldIdx::from_usize` in InstSimplify)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request May 26, 2024
…kingjubilee

Rollup of 10 pull requests

Successful merges:

 - rust-lang#125046 (Only allow immutable statics with #[linkage])
 - rust-lang#125466 (Don't continue probing for method if in suggestion and autoderef hits ambiguity)
 - rust-lang#125469 (Don't skip out of inner const when looking for body for suggestion)
 - rust-lang#125530 (cleanup dependence of `ExtCtxt` in transcribe when macro expansion)
 - rust-lang#125535 (clean-up: remove deprecated field `dist.missing-tools`)
 - rust-lang#125539 (crashes: increment the number of tracked ones)
 - rust-lang#125544 (Also mention my-self for other check-cfg docs changes)
 - rust-lang#125559 (Simplify the `unchecked_sh[lr]` ub-checks a bit)
 - rust-lang#125566 (Notify T-rustdoc for beta-accepted and stable-accepted too)
 - rust-lang#125582 (Avoid a `FieldIdx::from_usize` in InstSimplify)

r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request May 26, 2024
crashes: increment the number of tracked ones

r? ``@jieyouxu``
jhpratt added a commit to jhpratt/rust that referenced this pull request May 26, 2024
crashes: increment the number of tracked ones

r? ```@jieyouxu```
@workingjubilee
Copy link
Member

@bors r-

Conflicts with #125466

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 26, 2024
@workingjubilee workingjubilee added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label May 26, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete this.

Copy link
Member

@workingjubilee workingjubilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has even more conflicts, actually, a bunch of these crashes need to go away:

#125592 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one too, please.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you would.

@rust-log-analyzer

This comment has been minimized.

@matthiaskrgr
Copy link
Member Author

lol
@jieyouxu fwiw if I set something to rollup=iffy there is usually a good reason for it:D

@bors rollup=iffy

@jieyouxu
Copy link
Member

lol @jieyouxu fwiw if I set something to rollup=iffy there is usually a good reason for it:D

Oh sorry, I missed the rollup=iffy comment...

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 27, 2024
@matthiaskrgr matthiaskrgr removed the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label May 27, 2024
@matthiaskrgr
Copy link
Member Author

I've added the last couple of new ices, removed duplicates, added a fixed one as ui test and update one ui test to link to the corresponding ice ticket.
lets give this another go
@bors r=jieyouxu

@bors
Copy link
Collaborator

bors commented May 27, 2024

📌 Commit 894386a has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 27, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 27, 2024
crashes: increment the number of tracked ones

r? `@jieyouxu`
bors added a commit to rust-lang-ci/rust that referenced this pull request May 27, 2024
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#125339 (The number of tests does not depend on the architecture's pointer width)
 - rust-lang#125539 (crashes: increment the number of tracked ones)
 - rust-lang#125542 (Migrate rustdoc verify output files)
 - rust-lang#125613 (Use `rmake` for `windows-` run-make tests)
 - rust-lang#125616 (MIR validation: ensure that downcast projection is followed by field projection)

Failed merges:

 - rust-lang#125573 (Migrate `run-make/allow-warnings-cmdline-stability` to `rmake.rs`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented May 27, 2024

⌛ Testing commit 894386a with merge 37b74b3...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 27, 2024
crashes: increment the number of tracked ones

r? `@jieyouxu`
@matthiaskrgr
Copy link
Member Author

matthiaskrgr commented May 27, 2024

test needed to be x86 only
@bors r=jieyouxu

@bors
Copy link
Collaborator

bors commented May 27, 2024

📌 Commit bae9452 has been approved by jieyouxu

It is now in the queue for this repository.

bors added a commit to rust-lang-ci/rust that referenced this pull request May 27, 2024
crashes: increment the number of tracked ones

r? `@jieyouxu`
@bors
Copy link
Collaborator

bors commented May 27, 2024

⌛ Testing commit bae9452 with merge 9081198...

@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
test [ui] tests/ui/const-generics/generic_const_exprs/ice-predicates-of-no-entry-found-for-key-119275.rs ... ok
test [ui] tests/ui/const-generics/generic_const_exprs/inline-const-in-const-generic-defaults.rs ... ok
test [ui] tests/ui/const-generics/generic_const_exprs/elaborate-trait-pred.rs ... ok
test [ui] tests/ui/const-generics/generic_const_exprs/issue-100360.rs ... ok
test [ui] tests/ui/const-generics/generic_const_exprs/ice-125520-layout-mismatch-mulwithoverflow.rs ... ok
test [ui] tests/ui/const-generics/generic_const_exprs/from-sig.rs ... ok
test [ui] tests/ui/const-generics/generic_const_exprs/issue-105608.rs ... ok
test [ui] tests/ui/const-generics/generic_const_exprs/issue-105257.rs ... ok
test [ui] tests/ui/const-generics/generic_const_exprs/issue-102074.rs ... ok
---
##[endgroup]
[TIMING] core::build_steps::tool::ToolBuild { compiler: Compiler { stage: 0, host: aarch64-unknown-linux-gnu }, target: aarch64-unknown-linux-gnu, tool: "linkchecker", path: "src/tools/linkchecker", mode: ToolBootstrap, source_type: InTree, extra_features: [], allow_features: "" } -- 0.222
[TIMING] core::build_steps::tool::Linkchecker { compiler: Compiler { stage: 0, host: aarch64-unknown-linux-gnu }, target: aarch64-unknown-linux-gnu } -- 0.004
##[group]Testing stage0 Linkcheck (aarch64-unknown-linux-gnu)
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

Session terminated, killing shell...::group::Clock drift check
  network time: Tue, 28 May 2024 00:01:52 GMT
##[endgroup]
checked links in: 31.6s
number of HTML files scanned: 38518

@bors
Copy link
Collaborator

bors commented May 28, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 28, 2024
@workingjubilee
Copy link
Member

blaming this one on the internet

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 28, 2024
@bors
Copy link
Collaborator

bors commented May 28, 2024

⌛ Testing commit bae9452 with merge 71213fd...

@bors
Copy link
Collaborator

bors commented May 28, 2024

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 71213fd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 28, 2024
@bors bors merged commit 71213fd into rust-lang:master May 28, 2024
7 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 28, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (71213fd): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.6% [2.6%, 2.6%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.6% [2.6%, 2.6%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.323s -> 668.641s (-0.10%)
Artifact size: 318.28 MiB -> 318.24 MiB (-0.01%)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants