Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix ICE caused by ignoring EffectVars in type inference #125865

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Fix ICE caused by ignoring EffectVars in type inference #125865

merged 1 commit into from
Jun 4, 2024

Conversation

ajwock
Copy link
Contributor

@ajwock ajwock commented Jun 1, 2024

Fixes #119830
​r? @matthiaskrgr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 1, 2024
@compiler-errors
Copy link
Member

r? fee1-dead

@rustbot rustbot assigned fee1-dead and unassigned matthiaskrgr Jun 2, 2024
fee1-dead
fee1-dead reviewed Jun 3, 2024
View reviewed changes
tests/ui/specialization/spec-effectvar-ice.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move to tests/ui/rfcs/rfc-2632-const_trait_impl/effects

@ajwock
Fix ICE caused by ignoring EffectVars in type inference
66a1386 
Signed-off-by: Andrew Wock <ajwock@gmail.com>
@ajwock ajwock force-pushed the ice_not_fully_resolved branch from 35a6916 to 66a1386 Compare June 3, 2024 11:19
@fee1-dead
Copy link
Member

LGTM, thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Jun 3, 2024

📌 Commit 66a1386 has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 3, 2024
@matthiaskrgr
Rollup merge of rust-lang#125865 - ajwock:ice_not_fully_resolved, r=f…
374460d 
…ee1-dead

Fix ICE caused by ignoring EffectVars in type inference

Fixes rust-lang#119830
​r? `@matthiaskrgr`
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 3, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 3, 2024
@bors
Auto merge of rust-lang#125931 - matthiaskrgr:rollup-m3lqr4i, r=matth…
6a518ff 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#122597 (Show files produced by `--emit foo` in json artifact notifications)
 - rust-lang#124486 (Add tracking issue and unstable book page for `"vectorcall"` ABI)
 - rust-lang#125380 (Make `WHERE_CLAUSES_OBJECT_SAFETY` a regular object safety violation)
 - rust-lang#125690 (ARM Target Docs Update)
 - rust-lang#125865 (Fix ICE caused by ignoring EffectVars in type inference)
 - rust-lang#125893 (Handle all GVN binops in a single place.)
 - rust-lang#125909 (rustdoc: add a regression test for a former blanket impl synthesis ICE)
 - rust-lang#125918 (Revert: create const block bodies in typeck via query feeding)
 - rust-lang#125919 (Remove stray "this")

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 3, 2024
@bors
Auto merge of rust-lang#125931 - matthiaskrgr:rollup-m3lqr4i, r=matth…
f06dc4f 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#122597 (Show files produced by `--emit foo` in json artifact notifications)
 - rust-lang#124486 (Add tracking issue and unstable book page for `"vectorcall"` ABI)
 - rust-lang#125380 (Make `WHERE_CLAUSES_OBJECT_SAFETY` a regular object safety violation)
 - rust-lang#125690 (ARM Target Docs Update)
 - rust-lang#125865 (Fix ICE caused by ignoring EffectVars in type inference)
 - rust-lang#125893 (Handle all GVN binops in a single place.)
 - rust-lang#125909 (rustdoc: add a regression test for a former blanket impl synthesis ICE)
 - rust-lang#125918 (Revert: create const block bodies in typeck via query feeding)
 - rust-lang#125919 (Remove stray "this")

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 3, 2024
@matthiaskrgr
Rollup merge of rust-lang#125865 - ajwock:ice_not_fully_resolved, r=f…
183ad51 
…ee1-dead

Fix ICE caused by ignoring EffectVars in type inference

Fixes rust-lang#119830
​r? ``@matthiaskrgr``
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 3, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 3, 2024
@bors
Auto merge of rust-lang#125938 - matthiaskrgr:rollup-nufugmb, r=matth…
c2d9e06 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#122597 (Show files produced by `--emit foo` in json artifact notifications)
 - rust-lang#124486 (Add tracking issue and unstable book page for `"vectorcall"` ABI)
 - rust-lang#125690 (ARM Target Docs Update)
 - rust-lang#125865 (Fix ICE caused by ignoring EffectVars in type inference)
 - rust-lang#125893 (Handle all GVN binops in a single place.)
 - rust-lang#125909 (rustdoc: add a regression test for a former blanket impl synthesis ICE)
 - rust-lang#125918 (Revert: create const block bodies in typeck via query feeding)
 - rust-lang#125919 (Remove stray "this")
 - rust-lang#125927 (Ignore `vec_deque_alloc_error::test_shrink_to_unwind` test on non-unwind targets)

r? `@ghost`
`@rustbot` modify labels: rollup
@compiler-errors compiler-errors mentioned this pull request Jun 4, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 4, 2024
@bors
Auto merge of rust-lang#125976 - compiler-errors:rollup-xt3le7w, r=co…
30ea1a2 
…mpiler-errors

Rollup of 8 pull requests

Successful merges:

 - rust-lang#125667 (Silence follow-up errors directly based on error types and regions)
 - rust-lang#125717 (Refactor `#[diagnostic::do_not_recommend]` support)
 - rust-lang#125795 (Improve renaming suggestion for names with leading underscores)
 - rust-lang#125865 (Fix ICE caused by ignoring EffectVars in type inference)
 - rust-lang#125953 (Streamline `nested` calls.)
 - rust-lang#125959 (Reduce `pub` exposure in `rustc_mir_build`)
 - rust-lang#125967 (Split smir `Const` into `TyConst` and `MirConst`)
 - rust-lang#125968 (Store the types of `ty::Expr` arguments in the `ty::Expr`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7699da4 into rust-lang:master Jun 4, 2024
6 checks passed
@rustbot rustbot added this to the 1.80.0 milestone Jun 4, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 4, 2024
@rust-timer
Unrolled build for rust-lang#125865
7ae9344 
Rollup merge of rust-lang#125865 - ajwock:ice_not_fully_resolved, r=fee1-dead

Fix ICE caused by ignoring EffectVars in type inference

Fixes rust-lang#119830
​r? ```@matthiaskrgr```
@fee1-dead fee1-dead added PG-const-traits Project group: Const traits F-const_trait_impl `#![feature(const_trait_impl)]` F-effects `#![feature(effects)]` and removed F-const_trait_impl `#![feature(const_trait_impl)]` labels Aug 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fee1-dead fee1-dead fee1-dead left review comments

Assignees

@fee1-dead fee1-dead

Labels
F-effects `#![feature(effects)]` PG-const-traits Project group: Const traits S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.

ice: is not fully resolved
6 participants
@ajwock @compiler-errors @fee1-dead @bors @matthiaskrgr @rustbot