Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Orphanck[old solver]: Consider opaque types to never cover type parameters #125871

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Orphanck[old solver]: Consider opaque types to never cover type parameters #125871

merged 1 commit into from
Jun 5, 2024

Conversation

fmease
Copy link
Member

@fmease fmease commented Jun 1, 2024 •
edited
Loading

This fixes an oversight of mine in #117164. The change itself has already been FCP'ed.

This only affects the old solver, the next solver already correctly rejects the added test since #117164.

r? @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 1, 2024
@fmease fmease force-pushed the fix-orphanck-opaques branch 4 times, most recently from cad4e89 to f801823 Compare June 2, 2024 01:51
lcnr
lcnr reviewed Jun 3, 2024
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits, then r=me

thanks

@fmease fmease added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2024
@fmease fmease changed the title Orphanck: Consider opaque types to never cover type parameters [fix for old solver] Orphanck[old solver]: Consider opaque types to never cover type parameters Jun 4, 2024
@fmease fmease force-pushed the fix-orphanck-opaques branch from f801823 to 8746703 Compare June 4, 2024 16:58
@fmease
Copy link
Member Author

fmease commented Jun 4, 2024

@bors r=lcnr

@bors
Copy link
Contributor

bors commented Jun 4, 2024

📌 Commit 8746703 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 4, 2024
fmease added a commit to fmease/rust that referenced this pull request Jun 4, 2024
@fmease
Rollup merge of rust-lang#125871 - fmease:fix-orphanck-opaques, r=lcnr
323aa7e 
Orphanck[old solver]: Consider opaque types to never cover type parameters

This fixes an oversight of mine in rust-lang#117164. The change itself has already been FCP'ed.

This only affects the old solver, the next solver already correctly rejects the added test since rust-lang#117164.

r? `@lcnr`
@fmease fmease mentioned this pull request Jun 4, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 5, 2024
@bors
Auto merge of rust-lang#126001 - fmease:rollup-c2h2zao, r=fmease
fd69c35 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#122192 (Do not try to reveal hidden types when trying to prove Freeze in the defining scope)
 - rust-lang#124840 (resolve: mark it undetermined if single import is not has any bindings)
 - rust-lang#125622 (Winnow private method candidates instead of assuming any candidate of the right name will apply)
 - rust-lang#125871 (Orphanck[old solver]: Consider opaque types to never cover type parameters)
 - rust-lang#125893 (Handle all GVN binops in a single place.)
 - rust-lang#125911 (delete bootstrap build before switching to bumped rustc)
 - rust-lang#125918 (Revert: create const block bodies in typeck via query feeding)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 5, 2024
@bors
Auto merge of rust-lang#126001 - fmease:rollup-c2h2zao, r=fmease
fea7c2a 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#122192 (Do not try to reveal hidden types when trying to prove Freeze in the defining scope)
 - rust-lang#124840 (resolve: mark it undetermined if single import is not has any bindings)
 - rust-lang#125622 (Winnow private method candidates instead of assuming any candidate of the right name will apply)
 - rust-lang#125871 (Orphanck[old solver]: Consider opaque types to never cover type parameters)
 - rust-lang#125893 (Handle all GVN binops in a single place.)
 - rust-lang#125911 (delete bootstrap build before switching to bumped rustc)
 - rust-lang#125918 (Revert: create const block bodies in typeck via query feeding)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 5, 2024
@bors
Auto merge of rust-lang#126001 - fmease:rollup-c2h2zao, r=fmease
af4f558 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#122192 (Do not try to reveal hidden types when trying to prove Freeze in the defining scope)
 - rust-lang#124840 (resolve: mark it undetermined if single import is not has any bindings)
 - rust-lang#125622 (Winnow private method candidates instead of assuming any candidate of the right name will apply)
 - rust-lang#125871 (Orphanck[old solver]: Consider opaque types to never cover type parameters)
 - rust-lang#125893 (Handle all GVN binops in a single place.)
 - rust-lang#125911 (delete bootstrap build before switching to bumped rustc)
 - rust-lang#125918 (Revert: create const block bodies in typeck via query feeding)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 5, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 5, 2024
@bors
Auto merge of rust-lang#126038 - matthiaskrgr:rollup-h4rm3x2, r=matth…
72fdf91 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#124840 (resolve: mark it undetermined if single import is not has any bindings)
 - rust-lang#125622 (Winnow private method candidates instead of assuming any candidate of the right name will apply)
 - rust-lang#125648 (Remove unused(?) `~/rustsrc` folder from docker script)
 - rust-lang#125672 (Add more ABI test cases to miri (RFC 3391))
 - rust-lang#125800 (Fix `mut` static task queue in SGX target)
 - rust-lang#125871 (Orphanck[old solver]: Consider opaque types to never cover type parameters)
 - rust-lang#125893 (Handle all GVN binops in a single place.)
 - rust-lang#126008 (Port `tests/run-make-fulldeps/issue-19371` to ui-fulldeps)
 - rust-lang#126032 (Update description of the `IsTerminal` example)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9c8e46d into rust-lang:master Jun 5, 2024
6 checks passed
@rustbot rustbot added this to the 1.80.0 milestone Jun 5, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 5, 2024
@rust-timer
Unrolled build for rust-lang#125871
7c33661 
Rollup merge of rust-lang#125871 - fmease:fix-orphanck-opaques, r=lcnr

Orphanck[old solver]: Consider opaque types to never cover type parameters

This fixes an oversight of mine in rust-lang#117164. The change itself has already been FCP'ed.

This only affects the old solver, the next solver already correctly rejects the added test since rust-lang#117164.

r? ``@lcnr``
@fmease fmease deleted the fix-orphanck-opaques branch June 6, 2024 00:16
@fmease
Copy link
Member Author

fmease commented Jun 6, 2024

bors sleepy @bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 6, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lcnr lcnr lcnr left review comments

Assignees

@lcnr lcnr

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.
4 participants
@fmease @bors @lcnr @rustbot