Skip to content

Call the target libdir target libdir #126136

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2024
Merged

Call the target libdir target libdir #126136

merged 1 commit into from
Nov 4, 2024

Conversation

Noratrieb
Copy link
Member

Because it's the target libdir.

--print uses the same terminology, and it's a simple way to make it obviously different from $sysroot/lib.

@rustbot
Copy link
Collaborator

rustbot commented Jun 7, 2024

r? @onur-ozkan

rustbot has assigned @onur-ozkan.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 7, 2024
@rust-lang rust-lang deleted a comment Jun 7, 2024
@onur-ozkan onur-ozkan added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2024
@JohnCSimon
Copy link
Member

@Noratrieb - ping from triage - can you post your status on this PR? This PR has not received an update in a few months.

FYI: when a PR is ready for review, send a message containing
@rustbot ready to switch to S-waiting-on-review so the PR is in the reviewer's backlog.

Or if you're not going to continue, please close it. Thank you!

@Noratrieb
Copy link
Member Author

uh I think it's ready for review actually oops
@rustbot ready
@onur-ozkan

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 4, 2024
onur-ozkan
onur-ozkan approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@onur-ozkan
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 4, 2024

📌 Commit 7627a54 has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2024
tgross35 added a commit to tgross35/rust that referenced this pull request Sep 5, 2024
@tgross35
Rollup merge of rust-lang#126136 - Noratrieb:bootstrap-naming, r=onur…
af3be23 
…-ozkan

Call the target libdir target libdir

Because it's the target libdir.

`--print` uses the same terminology, and it's a simple way to make it obviously different from `$sysroot/lib`.
@tgross35 tgross35 mentioned this pull request Sep 5, 2024
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 5, 2024
@matthiaskrgr
Rollup merge of rust-lang#126136 - Noratrieb:bootstrap-naming, r=onur…
cd2ce8d 
…-ozkan

Call the target libdir target libdir

Because it's the target libdir.

`--print` uses the same terminology, and it's a simple way to make it obviously different from `$sysroot/lib`.
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 5, 2024
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 5, 2024
@matthiaskrgr
Rollup merge of rust-lang#126136 - Noratrieb:bootstrap-naming, r=onur…
b514f52 
…-ozkan

Call the target libdir target libdir

Because it's the target libdir.

`--print` uses the same terminology, and it's a simple way to make it obviously different from `$sysroot/lib`.
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 5, 2024
Closed
@matthiaskrgr
Copy link
Member

@bors r-
#129993 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 5, 2024
@bors
Copy link
Collaborator

bors commented Sep 14, 2024

☔ The latest upstream changes (presumably #130332) made this pull request unmergeable. Please resolve the merge conflicts.

@alex-semenyuk alex-semenyuk removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 2, 2024
@alex-semenyuk alex-semenyuk added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 2, 2024
@Noratrieb
Call the target libdir target libdir
f42fb43 
Because it's the target libdir.

`--print` uses the same terminology, and it's a simple way to make it
obviously different from `$sysroot/lib`.
@Noratrieb
Copy link
Member Author

rebased
bootstrap compiles in CI, :shipit:
@bors r=onur-ozkan

@bors
Copy link
Collaborator

bors commented Nov 3, 2024

📌 Commit f42fb43 has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 3, 2024
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 3, 2024
@GuillaumeGomez
Rollup merge of rust-lang#126136 - Noratrieb:bootstrap-naming, r=onur…
d234c6f 
…-ozkan

Call the target libdir target libdir

Because it's the target libdir.

`--print` uses the same terminology, and it's a simple way to make it obviously different from `$sysroot/lib`.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 3, 2024
Closed
@workingjubilee workingjubilee mentioned this pull request Nov 3, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 4, 2024
@bors
Auto merge of rust-lang#132581 - workingjubilee:rollup-4wj318p, r=wor…
43c7805 
…kingjubilee

Rollup of 6 pull requests

Successful merges:

 - rust-lang#126136 (Call the target libdir target libdir)
 - rust-lang#132516 (Add bad-reg inline assembly ui test for RISC-V and s390x)
 - rust-lang#132521 (replace manual time convertions with std ones, comptime time format parsing)
 - rust-lang#132560 (Remove outdated tidy license fixmes)
 - rust-lang#132563 (Modify `NonZero` documentation to reference the underlying integer type)
 - rust-lang#132574 (compiler: Directly use rustc_abi almost everywhere)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit deb4ceb into rust-lang:master Nov 4, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 4, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 4, 2024
@rust-timer
Unrolled build for rust-lang#126136
f01977f 
Rollup merge of rust-lang#126136 - Noratrieb:bootstrap-naming, r=onur-ozkan

Call the target libdir target libdir

Because it's the target libdir.

`--print` uses the same terminology, and it's a simple way to make it obviously different from `$sysroot/lib`.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@onur-ozkan onur-ozkan onur-ozkan approved these changes

Assignees

@onur-ozkan onur-ozkan

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Noratrieb @rustbot @JohnCSimon @onur-ozkan @bors @matthiaskrgr @alex-semenyuk