-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Migrate run-make/multiple-emits
to rmake.rs
#126186
Migrate run-make/multiple-emits
to rmake.rs
#126186
Conversation
Some changes occurred in run-make tests. cc @jieyouxu |
Yeah, sorry for the support library changes :3 I'll try to draft up some docs for the support library to help test writers navigate and work with the support library later today/tomorrow to hopefully make this less painful. @rustbot author |
927b889
to
e8b04cc
Compare
The run-make-support library was changed cc @jieyouxu |
Added the @bors ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately bors is not ready 😆
Thanks for the fixes, feel free to r=me after CI is green!
@bors r=jieyouxu (Wanted to approve this, but jieyouxu got here first, so I r'd it :) ). |
Rollup of 5 pull requests Successful merges: - rust-lang#126186 (Migrate `run-make/multiple-emits` to `rmake.rs`) - rust-lang#126236 (Delegation: fix ICE on recursive delegation) - rust-lang#126254 (Remove ignore-cross-compile directive from ui/macros/proc_macro) - rust-lang#126258 (Do not define opaque types when selecting impls) - rust-lang#126265 (interpret: ensure we check bool/char for validity when they are used in a cast) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#126186 - GuillaumeGomez:migrate-run-make-multiple-emits, r=jieyouxu Migrate `run-make/multiple-emits` to `rmake.rs` Part of rust-lang#121876. r? `@jieyouxu`
Part of #121876.
r? @jieyouxu