Detect pub structs never constructed even though they impl pub trait with assoc constants #126276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
rustbot
added
S-waiting-on-review
fee1-dead
requested changes
Jun 12, 2024
tests/ui/lint/dead-code/unused-adt-impl-pub-trait-with-assoc-const.rs
Outdated
Show resolved
Hide resolved
rustbot
added
S-waiting-on-author
…with assoc constants
|
@rustbot ready |
rustbot
added
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 12, 2024
…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#125869 (Add `target_env = "p1"` to the `wasm32-wasip1` target) - rust-lang#126019 (Add TODO comment to unsafe env modification) - rust-lang#126036 (Migrate `run-make/short-ice` to `rmake`) - rust-lang#126276 (Detect pub structs never constructed even though they impl pub trait with assoc constants) - rust-lang#126282 (Ensure self-contained linker is only enabled on dev/nightly ) - rust-lang#126317 (Avoid a bunch of booleans in favor of Result<(), ErrorGuaranteed> as that more robustly proves that an error has been emitted) - rust-lang#126324 (Adjust LoongArch64 data layouts for LLVM update) - rust-lang#126340 (Fix outdated predacates_of.rs comments) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 12, 2024
Rollup merge of rust-lang#126276 - mu001999-contrib:dead/enhance, r=fee1-dead Detect pub structs never constructed even though they impl pub trait with assoc constants Extend dead code analysis to impl items of pub assoc constants. <!-- If this PR is related to an unstable feature or an otherwise tracked effort, please link to the relevant tracking issue here. If you don't know of a related tracking issue or there are none, feel free to ignore this. This PR will get automatically assigned to a reviewer. In case you would like a specific user to review your work, you can assign it to them by using r? <reviewer name> -->
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend dead code analysis to impl items of pub assoc constants.