Skip to content

std: add reserve_additional and an Extendable impl to Vec. #12673

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 4, 2014

Conversation

huonw
Copy link
Member

@huonw huonw commented Mar 3, 2014

std: add reserve_additional and an Extendable impl to Vec.

@Aatch
Copy link
Contributor

Aatch commented Mar 3, 2014

Could you add some tests? It's not a huge issue, but it would be nice.

@@ -125,6 +125,15 @@ impl<T> FromIterator<T> for Vec<T> {
vector
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a newline here :)

@thestinger
Copy link
Contributor

@Aatch: I think this stuff does already have tests for ~[T]. The tests should probably be ported over to Vec<T> since ~[T] will be gone soon.

@Aatch
Copy link
Contributor

Aatch commented Mar 3, 2014

@thestinger I didn't realise that weren't actually any tests in vec_ng.

@huonw
Copy link
Member Author

huonw commented Mar 3, 2014

Now comes with free tests! (Don't miss out. Call now to place your order.)

bors added a commit that referenced this pull request Mar 3, 2014
std: add reserve_additional and an Extendable impl to Vec.
@bors bors closed this Mar 4, 2014
@bors bors merged commit 6cb34cf into rust-lang:master Mar 4, 2014
@huonw huonw deleted the extendable-vec branch June 27, 2014 06:48
flip1995 pushed a commit to flip1995/rust that referenced this pull request Apr 18, 2024
…rs, r=blyxyas

[`ptr_as_ptr`]: Fix duplicate diagnostics

Relates to rust-lang/rust-clippy#12379

`ptr_as_ptr::check` is called twice in `clippy_lints/src/casts/mod.rs`

---

changelog: [`ptr_as_ptr`]: Fix duplicate diagnostics
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants