Skip to content

out_of_scope_macro_calls: Detect calls inside attributes more precisely #126987

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2024
Merged

out_of_scope_macro_calls: Detect calls inside attributes more precisely #126987

merged 1 commit into from
Jul 7, 2024

Conversation

petrochenkov
Copy link
Contributor

Fixes #126984.

@rustbot
Copy link
Collaborator

rustbot commented Jun 26, 2024

r? @pnkfelix

rustbot has assigned @pnkfelix.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 26, 2024
@petrochenkov petrochenkov mentioned this pull request Jun 26, 2024
Closed
@tgross35 tgross35 mentioned this pull request Jun 30, 2024
Merged
@petrochenkov
Copy link
Contributor Author

Ping @pnkfelix, this fixes a regression in compiler-builtins.

@pnkfelix
Copy link
Member

pnkfelix commented Jul 5, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 5, 2024

📌 Commit af9f6f7 has been approved by pnkfelix

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 5, 2024
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jul 5, 2024
@workingjubilee
Rollup merge of rust-lang#126987 - petrochenkov:atvisord2, r=pnkfelix
03a9b01 
out_of_scope_macro_calls: Detect calls inside attributes more precisely

Fixes rust-lang#126984.
@workingjubilee workingjubilee mentioned this pull request Jul 5, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 5, 2024
@bors
Auto merge of rust-lang#127400 - workingjubilee:rollup-9894l8q, r=wor…
d956223 
…kingjubilee

Rollup of 11 pull requests

Successful merges:

 - rust-lang#123600 (impl PathBuf::add_extension and Path::with_added_extension)
 - rust-lang#126987 (out_of_scope_macro_calls: Detect calls inside attributes more precisely)
 - rust-lang#127107 (Improve dead code analysis)
 - rust-lang#127221 (Improve well known value check-cfg diagnostic for the standard library)
 - rust-lang#127333 (Split `SolverDelegate` back out from `InferCtxtLike`)
 - rust-lang#127363 (Improve readability of some fmt code examples)
 - rust-lang#127366 (Use `ControlFlow` results for visitors that are only looking for a single value)
 - rust-lang#127368 (Added dots at the sentence ends of rustc AST doc)
 - rust-lang#127369 (Match ergonomics 2024: align with RFC again)
 - rust-lang#127383 (Use verbose style for argument removal suggestion)
 - rust-lang#127393 (Remove clubby789 from review rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
@compiler-errors
Copy link
Member

Failed in a rollup: #127400 (comment)

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 6, 2024
@petrochenkov

This comment was marked as outdated.

# to view
@petrochenkov

This comment was marked as outdated.

# to view
1 similar comment
@petrochenkov
Copy link
Contributor Author

@bors r=pnkfelix

@bors
Copy link
Collaborator

bors commented Jul 6, 2024

📌 Commit 83cf471 has been approved by pnkfelix

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 6, 2024
@bors
Copy link
Collaborator

bors commented Jul 6, 2024

⌛ Testing commit 83cf471 with merge 6ba80a9...

@bors
Copy link
Collaborator

bors commented Jul 7, 2024

☀️ Test successful - checks-actions
Approved by: pnkfelix
Pushing 6ba80a9 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 7, 2024
@bors bors merged commit 6ba80a9 into rust-lang:master Jul 7, 2024
7 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jul 7, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6ba80a9): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 1.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.3% [0.4%, 2.0%] 6
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

Results (secondary 0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.2% [4.2%, 4.2%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.6% [-0.8%, -0.4%] 4
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 700.852s -> 700.652s (-0.03%)
Artifact size: 328.40 MiB -> 328.40 MiB (-0.00%)

@petrochenkov petrochenkov deleted the atvisord2 branch February 22, 2025 18:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.

Regression from new lint out_of_scope_macro_calls
6 participants
@petrochenkov @rustbot @pnkfelix @bors @compiler-errors @rust-timer