-
Notifications
You must be signed in to change notification settings - Fork 13.4k
rustc_codegen_llvm: less pubs #127274
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
rustc_codegen_llvm: less pubs #127274
Conversation
#[allow(dead_code)] | ||
pub enum TypeKind { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This suspiciously unused, TypeKind
from rustc_codegen_ssa
used around instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is #85677
Could we use |
Why not just remove the dead code? |
Some changes occurred in coverage instrumentation. cc @Zalathar |
The job Click to see the possible cause of the failure (guessed by this bot)
|
☔ The latest upstream changes (presumably #125443) made this pull request unmergeable. Please resolve the merge conflicts. |
@klensy |
@klensy |
This removes few pubs around and slaps
dead_code
s around.