Fix a bunch of sites that were walking instead of visiting, making it impossible for visitor impls to look at these values #127817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… impossible for visitor impls to look at these values
|
rustbot has assigned @petrochenkov. Use |
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 16, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#127669 (Fix the issue of invalid suggestion for a reference of iterator) - rust-lang#127707 (match lowering: Use an iterator to find `expand_until`) - rust-lang#127730 (Fix and enforce `unsafe_op_in_unsafe_fn` in compiler) - rust-lang#127789 (delete #![allow(unsafe_op_in_unsafe_fn)] in teeos) - rust-lang#127805 (run-make-support: update gimli to 0.31.0) - rust-lang#127808 (Make ErrorGuaranteed discoverable outside types, consts, and lifetimes) - rust-lang#127817 (Fix a bunch of sites that were walking instead of visiting, making it impossible for visitor impls to look at these values) - rust-lang#127818 (Various ast validation simplifications) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 16, 2024
Rollup merge of rust-lang#127817 - oli-obk:mut_visitor_fix, r=petrochenkov Fix a bunch of sites that were walking instead of visiting, making it impossible for visitor impls to look at these values This doesn't affects anything right now, but a `MutVisitor` impl could be surprised by this. The reason this doesn't affect anything is that no one overrrides `visit_lifetime` or `visit_param_bounds` currently.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't affects anything right now, but a
MutVisitorimpl could be surprised by this.The reason this doesn't affect anything is that no one overrrides
visit_lifetimeorvisit_param_boundscurrently.