Skip to content

Improve error when a compiler/library build fails in checktools.sh #127934

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2024
Merged

Improve error when a compiler/library build fails in checktools.sh #127934

merged 1 commit into from
Jul 19, 2024

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jul 18, 2024

Suggested by @RalfJung here.

x86_64-gnu-tools should take ~45 minutes, let's see if this doesn't regress it.

r? @onur-ozkan

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 18, 2024
@onur-ozkan
Copy link
Member

Makes sense!

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 19, 2024

📌 Commit af95fd6 has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2024
@Kobzol
Copy link
Contributor Author

Kobzol commented Jul 19, 2024

I checked the build logs now and it is building perhaps too much stuff, including things like miri, cargo, rust-analyzer etc. The following step only needs the compiler toolchain including rustdoc though. Is there a simple x build command that builds compiler + stdlib + rustdoc? Is x build --stage 2 library enough? 🤔

@onur-ozkan
Copy link
Member

Maybe you can try to give each component name explicitly. Something like x build compiler library rustdoc --stage 2.

@RalfJung
Copy link
Member

@bors r-
while this is being discussed

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 19, 2024
@Kobzol Kobzol force-pushed the checktools-better-error branch from af95fd6 to e3a22c9 Compare July 19, 2024 12:37
@Kobzol
Copy link
Contributor Author

Kobzol commented Jul 19, 2024

Let's try x build compiler rustdoc (library seemed to by redundant in my experiments).

@onur-ozkan
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 19, 2024

📌 Commit e3a22c9 has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 19, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 19, 2024
@matthiaskrgr
Rollup merge of rust-lang#127934 - Kobzol:checktools-better-error, r=…
ac3bd9a 
…onur-ozkan

Improve error when a compiler/library build fails in `checktools.sh`

Suggested by `@RalfJung` [here](rust-lang#127869 (comment)).

`x86_64-gnu-tools` should take ~45 minutes, let's see if this doesn't regress it.

r? `@onur-ozkan`
This was referenced Jul 19, 2024
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 19, 2024
@bors
Auto merge of rust-lang#127969 - matthiaskrgr:rollup-nhxmwhn, r=matth…
0cd01aa 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#112328 (Feat. adding ext that returns change_time)
 - rust-lang#126199 (Add `isqrt` to `NonZero<uN>`)
 - rust-lang#127856 (interpret: add sanity check in dyn upcast to double-check what codegen does)
 - rust-lang#127934 (Improve error when a compiler/library build fails in `checktools.sh`)
 - rust-lang#127960 (Cleanup dll/exe filename calculations in `run_make_support`)
 - rust-lang#127963 (Fix display of logo "border")
 - rust-lang#127967 (Disable run-make/split-debuginfo test for RISC-V 64)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 32b9725 into rust-lang:master Jul 19, 2024
6 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jul 19, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 19, 2024
@rust-timer
Unrolled build for rust-lang#127934
6459335 
Rollup merge of rust-lang#127934 - Kobzol:checktools-better-error, r=onur-ozkan

Improve error when a compiler/library build fails in `checktools.sh`

Suggested by ``@RalfJung`` [here](rust-lang#127869 (comment)).

`x86_64-gnu-tools` should take ~45 minutes, let's see if this doesn't regress it.

r? ``@onur-ozkan``
@Kobzol Kobzol deleted the checktools-better-error branch July 19, 2024 18:40
@onur-ozkan onur-ozkan mentioned this pull request Jul 20, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@onur-ozkan onur-ozkan

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Kobzol @onur-ozkan @bors @RalfJung @rustbot