Skip to content

[compiletest] Search *.a when getting dynamic libraries on AIX #127953

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2024
Merged

[compiletest] Search *.a when getting dynamic libraries on AIX #127953

merged 2 commits into from
Jul 19, 2024

Conversation

bzEq
Copy link
Contributor

@bzEq bzEq commented Jul 19, 2024

AIX uses .a as dylib suffix. Support it in compiletest.

@rustbot
Copy link
Collaborator

rustbot commented Jul 19, 2024

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jul 19, 2024

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jul 19, 2024
@bzEq
Copy link
Contributor Author

bzEq commented Jul 19, 2024

No sure I have to revert the format change introduced. It should be formatted automatically by git hooks.

@rust-log-analyzer

This comment has been minimized.

# to view
@tgross35
Copy link
Contributor

Does ./x.py fmt fix things for you? I don't think the hook actually formats anything but should reject incorrect formatting, weird

@bzEq
Copy link
Contributor Author

bzEq commented Jul 19, 2024

Does ./x.py fmt fix things for you?

Thanks for the info. I ran rustfmt manually to fix the issue.

jieyouxu
jieyouxu approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Note that other places in test suites (such as src/tools/run_make_support) does not know this, and you may have to also teach this extension to the test suites to get consistent test results on AIX.
EDIT: and also bootstrap potentially.

@jieyouxu
Copy link
Member

r? jieyouxu
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 19, 2024

📌 Commit ec805d1 has been approved by jieyouxu

It is now in the queue for this repository.

@rustbot rustbot assigned jieyouxu and unassigned wesleywiser Jul 19, 2024
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2024
@tgross35 tgross35 mentioned this pull request Jul 19, 2024
Merged
@bzEq
Copy link
Contributor Author

bzEq commented Jul 19, 2024

Much appreciated for your guidance, I'll take a look at that.

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 19, 2024
@bors
Auto merge of rust-lang#127956 - tgross35:rollup-8ten7pk, r=tgross35
11e5724 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#121533 (Handle .init_array link_section specially on wasm)
 - rust-lang#127825 (Migrate `macos-fat-archive`, `manual-link` and `archive-duplicate-names` `run-make` tests to rmake)
 - rust-lang#127891 (Tweak suggestions when using incorrect type of enum literal)
 - rust-lang#127902 (`collect_tokens_trailing_token` cleanups)
 - rust-lang#127928 (Migrate `lto-smoke-c` and `link-path-order` `run-make` tests to rmake)
 - rust-lang#127935 (Change `binary_asm_labels` to only fire on x86 and x86_64)
 - rust-lang#127953 ([compiletest] Search *.a when getting dynamic libraries on AIX)

r? `@ghost`
`@rustbot` modify labels: rollup
jieyouxu
jieyouxu reviewed Jul 19, 2024
View reviewed changes
@jieyouxu jieyouxu mentioned this pull request Jul 19, 2024
Merged
@bors bors merged commit 314cf1f into rust-lang:master Jul 19, 2024
6 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jul 19, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 19, 2024
@rust-timer
Unrolled build for rust-lang#127953
5606ade 
Rollup merge of rust-lang#127953 - bzEq:aix-compiletest-dylib-suffix, r=jieyouxu

[compiletest] Search *.a when getting dynamic libraries on AIX

AIX uses `.a` as dylib suffix. Support it in compiletest.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.
7 participants
@bzEq @rustbot @rust-log-analyzer @tgross35 @jieyouxu @bors @wesleywiser