Skip to content

Add limit for unclosed delimiters in lexer diagnostic #127955

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

chenyukang
Copy link
Member

Fixes #127868

The first commit shows the original diagnostic, and the second commit shows the changes.

@rustbot
Copy link
Collaborator

rustbot commented Jul 19, 2024

r? @michaelwoerister

rustbot has assigned @michaelwoerister.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 19, 2024
@chenyukang chenyukang force-pushed the yukang-fix-mismatched-delimiter-issue-12786 branch from fcdbd21 to b35d173 Compare July 19, 2024 07:10
@chenyukang
Copy link
Member Author

r? lexer

@nnethercote
Copy link
Contributor

Thanks for splitting this into two commits, it helps with the reviewing :)

r=me once the minor comments above are addressed.

@chenyukang chenyukang force-pushed the yukang-fix-mismatched-delimiter-issue-12786 branch from b35d173 to 52bc90c Compare July 25, 2024 07:55
@chenyukang
Copy link
Member Author

@bors r=nnethercote

@bors
Copy link
Collaborator

bors commented Jul 25, 2024

📌 Commit 52bc90c has been approved by nnethercote

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2024
@rust-log-analyzer

This comment has been minimized.

@chenyukang chenyukang force-pushed the yukang-fix-mismatched-delimiter-issue-12786 branch from 52bc90c to 94a3fd7 Compare July 25, 2024 09:01
@chenyukang
Copy link
Member Author

@bors r=nnethercote

@bors
Copy link
Collaborator

bors commented Jul 30, 2024

📌 Commit 94a3fd7 has been approved by nnethercote

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jul 30, 2024

⌛ Testing commit 94a3fd7 with merge 595316b...

@bors
Copy link
Collaborator

bors commented Jul 30, 2024

☀️ Test successful - checks-actions
Approved by: nnethercote
Pushing 595316b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 30, 2024
@bors bors merged commit 595316b into rust-lang:master Jul 30, 2024
7 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Jul 30, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (595316b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -0.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.9% [3.9%, 3.9%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-4.3% [-4.3%, -4.3%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.2% [-4.3%, 3.9%] 2

Cycles

Results (primary 2.6%, secondary -2.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.6% [2.6%, 2.6%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.5% [-2.5%, -2.5%] 1
All ❌✅ (primary) 2.6% [2.6%, 2.6%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 769.935s -> 768.761s (-0.15%)
Artifact size: 331.88 MiB -> 331.87 MiB (-0.00%)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Corrupted data trashes the output
7 participants