CStr: derive PartialEq, Eq; add test for Ord #128137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Merged
|
☔ The latest upstream changes (presumably #128155) made this pull request unmergeable. Please resolve the merge conflicts. |
GrigorenkoPV
force-pushed
the
cstr-derive
branch
from
8fe17ae to
cf9816c
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 25, 2024
CStr: derive PartialEq, Eq; add test for Ord While working on rust-lang#128046, I've spotted a peculiarity: `CStr` has `PartialEq, Eq, PartialOrd, Ord` implemented manually and not derived. While we can't derive `PartialOrd, Ord` (due to inner `[c_char]` being `[i8]` or `[u8]` on different platforms), we *can* derive `PartialEq, Eq` (I think), allowing as to remove `#[allow(clippy::derived_hash_with_manual_eq)]` as well. (I really hope `c_char: Eq` on all platforms)
This was referenced Jul 25, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#126908 (Use Cow<'static, str> for InlineAsmTemplatePiece::String) - rust-lang#127999 (Inject arm32 shims into Windows metadata generation) - rust-lang#128137 (CStr: derive PartialEq, Eq; add test for Ord) - rust-lang#128185 (Fix a span error when parsing a wrong param of function.) - rust-lang#128187 (Fix 1.80.0 version in RELEASES.md) - rust-lang#128189 (Turn an unreachable code path into an ICE) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2024
Rollup merge of rust-lang#128137 - GrigorenkoPV:cstr-derive, r=dtolnay CStr: derive PartialEq, Eq; add test for Ord While working on rust-lang#128046, I've spotted a peculiarity: `CStr` has `PartialEq, Eq, PartialOrd, Ord` implemented manually and not derived. While we can't derive `PartialOrd, Ord` (due to inner `[c_char]` being `[i8]` or `[u8]` on different platforms), we *can* derive `PartialEq, Eq` (I think), allowing as to remove `#[allow(clippy::derived_hash_with_manual_eq)]` as well. (I really hope `c_char: Eq` on all platforms)
carolynzech
added a commit
to model-checking/verify-rust-std
that referenced
this pull request
Aug 15, 2024
9cc3bc6 custom MIR: add support for tail calls 5674d1c Auto merge of rust-lang#128673 - matthiaskrgr:rollup-gtvpkm7, r=matthiaskrgr deb1d75 Rollup merge of rust-lang#128619 - glandium:last_chunk, r=scottmcm 6449537 Rollup merge of rust-lang#128609 - swenson:smaller-faster-dragon, r=Amanieu acb2c30 Rollup merge of rust-lang#128026 - devnexen:available_parallelism_vxworks, r=Mark-Simulacrum 89fe6df Rollup merge of rust-lang#128309 - kmicklas:btreeset-cursor, r=Amanieu 313484b Correct the const stabilization of `<[T]>::last_chunk` 22e026b Auto merge of rust-lang#128534 - bjorn3:split_stdlib_workspace, r=Mark-Simulacrum 1813603 Rollup merge of rust-lang#128526 - tshepang:patch-1, r=Amanieu e8a1a41 Auto merge of rust-lang#128466 - sayantn:stdarch-update, r=tgross35 2adf9da Update stdarch dc85bdb Chore: add `x86_amx_intrinsics` feature flag to `core/lib.rs` and remove `issue-120720-reduce-nan.rs` e88b04d Rollup merge of rust-lang#128551 - Konippi:refactor-backtrace-style-in-panic, r=tgross35 43a1e93 Rollup merge of rust-lang#128530 - scottmcm:repeat-n-unchecked, r=joboet 47df194 Remove unnecessary constants from flt2dec dragon 0b5f1b8 Auto merge of rust-lang#128404 - compiler-errors:revert-dead-code-changes, r=pnkfelix 35cd95f Suppress new false-negatives that were masked by dead code analysis changes 9eb9fa6 Revert "Rollup merge of rust-lang#127107 - mu001999-contrib:dead/enhance-2, r=pnkfelix" 975dc19 Rollup merge of rust-lang#128368 - nnethercote:rustfmt-tweaks, r=cuviper 0ee09fe Rollup merge of rust-lang#128303 - NobodyXu:specialise-for-pipe, r=cuviper 1967a12 Rollup merge of rust-lang#127586 - zachs18:more-must-use, r=cuviper fc53324 Rollup merge of rust-lang#126704 - sayantn:sha, r=Amanieu 74dd96f chore: refactor backtrace style in panic 0e4358d Auto merge of rust-lang#128528 - workingjubilee:you-dont-need-to-see-this-cpuid-move-along, r=Amanieu 9fa74ab Move the standard library to a separate workspace e13d132 Auto merge of rust-lang#128254 - Amanieu:orig-binary-search, r=tgross35 05d8d7c Implement `UncheckedIterator` directly for `RepeatN` a5fa13e Rollup merge of rust-lang#128491 - c410-f3r:unlock-rfc-2011, r=workingjubilee 28e4d22 Rollup merge of rust-lang#128453 - RalfJung:raw_eq, r=saethlin db770c6 std: Remove has_cpuid 39aad04 time.rs: remove "Basic usage text" 7df583c Dogfood cb11051 Add the `sha512`, `sm3` and `sm4` target features 86ea79f Fix mutability in doc tests for `BTreeSet` cursors c7be27f Introduce `Cursor`/`CursorMut`/`CursorMutKey` thrichotomy for `BTreeSet` like map API 8835b0f Fix some uses of "map" instead of "set" in `BTreeSet` cursor API docs 07f64a8 Share `UnorderedKeyError` with `BTReeMap` for set API f859e54 Rollup merge of rust-lang#128499 - Konippi:refactor-backtrace-formatting, r=tgross35 fb966d2 Rollup merge of rust-lang#128497 - Bryanskiy:fix-dropck-doc, r=lcnr ab00ae6 Rollup merge of rust-lang#128433 - hermit-os:hermit-unsafe_op_in_unsafe_fn, r=joboet 2614bd2 chore: refactor backtrace formatting a8a4659 fix dropck documentation for `[T;0]` special-case 589c0a0 fix(os/hermit): `deny(unsafe_op_in_unsafe_fn)` 0260e47 fix(pal/hermit): `deny(unsafe_op_in_unsafe_fn)` 7bd6b11 refactor(pal/hermit): make `ENV` a non-mutable static 32894e2 Rollup merge of rust-lang#128416 - maurer:remove-android-hack, r=tgross35 beb76c3 Auto merge of rust-lang#128461 - matthiaskrgr:rollup-3dpp11g, r=matthiaskrgr 1e3976b Rollup merge of rust-lang#128162 - ChrisDenton:cleanup, r=joboet cde45b0 Rollup merge of rust-lang#127567 - joboet:once_wait, r=Amanieu 0607642 Fix docs for OnceLock::get_mut_or_init da48417 raw_eq: using it on bytes with provenance is not UB (outside const-eval) cc6f37f std: fix busy-waiting in `Once::wait_force`, add more tests 6fd82f1 std: implement the `once_wait` feature 0c56873 Remove unneeded `pub(crate)` 787a1f7 Rollup merge of rust-lang#128388 - beetrees:f16-f128-slightly-improve-windows-abi, r=tgross35 e3a4ed3 Rollup merge of rust-lang#128387 - liigo:patch-14, r=tgross35 8b7f4ee refactor(pal/hermit): use default impl of `GlobalAlloc::alloc_zeroed` c337019 refactor(pal/hermit): return `!` to satisfy rust-analyzer 7aafdcf android: Remove libstd hacks for unsupported Android APIs ba65c6c Move Windows implementation of anon pipe 176508c Match LLVM ABI in `extern "C"` functions for `f128` on Windows 85e4ba0 Cleanup sys module to match house style ddff2b6 Auto merge of rust-lang#128083 - Mark-Simulacrum:bump-bootstrap, r=albertlarsan68 e4b0e6d Rewrite binary search implementation 556dc60 More detailed note to deprecate ONCE_INIT 440ec83 Auto merge of rust-lang#128378 - matthiaskrgr:rollup-i3qz9uo, r=matthiaskrgr a50fe57 Auto merge of rust-lang#128250 - Amanieu:select_unpredictable, r=nikic 47f9d61 Rollup merge of rust-lang#128315 - zetanumbers:psvita-unsafe-in-unsafe, r=workingjubilee f70ce7f Auto merge of rust-lang#128234 - jcsp:retain-empty-case, r=tgross35 93b2f7c Insert some blank lines. db0222e Move a comment. cc96f3e Stabilize offset_of_nested 618fdd5 Auto merge of rust-lang#128334 - matthiaskrgr:rollup-nhxdt0c, r=matthiaskrgr e088cb1 Rollup merge of rust-lang#128333 - RalfJung:miri-sync, r=RalfJung 1ea0493 Rollup merge of rust-lang#128307 - ojeda:unescaped_backticks, r=GuillaumeGomez 5d51099 Optimize empty case in Vec::retain f2bcbec Auto merge of rust-lang#125016 - nicholasbishop:bishop-cb-112, r=tgross35 7a43feb Rollup merge of rust-lang#128310 - kmicklas:btree-map-peek-next-docs, r=tgross35 03e5078 Rollup merge of rust-lang#128055 - workingjubilee:deny-unsafe-ops-in-sys-personality-dwarf-eh, r=Amanieu f9befad Rollup merge of rust-lang#109174 - soerenmeier:cursor_fns, r=dtolnay ed7d02f Update compiler_builtins to 0.1.114 80254cd Warn on `rustdoc::unescaped_backticks` for `core/alloc/std/test/proc_macro` c8db8ea Remove spurious backticks detected by `rustdoc::unescaped_backticks` d1d4fb3 Reformat `use` declarations. 3ec244f Replace `io::Cursor::{remaining_slice, is_empty}` with `io::Cursor::{split, split_mut}` abc611f step cfg(bootstrap) 78cd779 Update CURRENT_RUSTC_VERSION 70927dc Add forbid(unsafe_op_in_unsafe_fn) 06a22c9 Rollup merge of rust-lang#128240 - mbrubeck:patch-3, r=joboet 604d618 Rollup merge of rust-lang#128228 - slanterns:const_waker, r=dtolnay,oli-obk 2a70839 Rollup merge of rust-lang#128103 - folkertdev:unsigned-int-is-multiple-of, r=Amanieu 058f1d3 Rollup merge of rust-lang#127765 - bitfield:fix_stdlib_doc_nits, r=dtolnay 9a6c84e fix: psvita's std code 5119266 Force LLVM to use CMOV for binary search d6b6e63 stabilize const_waker 8e4f58a Add missing periods on `BTreeMap` cursor `peek_next` docs 458b9b0 Implement cursors for `BTreeSet` 02bf0de Enable `std::io::copy` specialisation for `std::pipe::{PipeReader, PipeWriter}` 1f83bf3 Rollup merge of rust-lang#128282 - pitaj:nonzero_bitwise, r=workingjubilee 357ff7a Rollup merge of rust-lang#128279 - slanterns:is_sorted, r=dtolnay fcbdcae stabilize `is_sorted` c47f8bd bitwise and bytewise methods on `NonZero` 4ea98d7 Rollup merge of rust-lang#128259 - sunshowers:msg-nosignal, r=Mark-Simulacrum d6f970a Rollup merge of rust-lang#125897 - RalfJung:from-ref, r=Amanieu 339f756 Auto merge of rust-lang#128255 - stepancheg:doc-shl, r=scottmcm 0d6a7dd Merge from rustc a66bc79 Auto merge of rust-lang#127946 - tgross35:fmt-builders-set-result, r=cuviper 2986bfe [illumos/solaris] set MSG_NOSIGNAL while writing to sockets 3e85493 Document int.checked_shl(BITS - 1) 59f3fef Rollup merge of rust-lang#128235 - harryscholes:fix-iterator-filter-docs, r=tgross35 a2dbfd3 Rollup merge of rust-lang#124941 - Skgland:stabilize-const-int-from-str, r=dtolnay 5b78bae Add links from `assert_eq!` docs to `debug_assert_eq!`, etc. a0f135d Always set `result` during `finish()` in debug builders bd11b3d Fix docs 22ce603 Auto merge of rust-lang#128165 - saethlin:optimize-clone-shims, r=compiler-errors fb7d2a8 Fix doc nits a152820 Rollup merge of rust-lang#128170 - saethlin:clone-fn, r=compiler-errors 0d63614 Merge from rustc cb8f69b Rollup merge of rust-lang#128211 - juliusl:pr/align-change-time, r=tgross35 ba0582b Rollup merge of rust-lang#128150 - BoxyUwU:std_only_sized_const_params, r=workingjubilee 30cfde4 Rollup merge of rust-lang#127950 - nnethercote:rustfmt-skip-on-use-decls, r=cuviper 8488ae6 Make Clone::clone a lang item 1342ef1 fix: compilation issue w/ refactored type 92c0ad7 Let InstCombine remove Clone shims inside Clone shims c788415 Stop using `unsized_const_parameters` in core/std ef4d4a0 Auto merge of rust-lang#128195 - matthiaskrgr:rollup-195dfdf, r=matthiaskrgr 5b6c1e1 Rollup merge of rust-lang#128137 - GrigorenkoPV:cstr-derive, r=dtolnay aaeac06 Rollup merge of rust-lang#127999 - ChrisDenton:arm32, r=Amanieu ea3a99f Rollup merge of rust-lang#128158 - workingjubilee:unsafe-wrap-personality-gcc, r=ChrisDenton 886fe5b Rollup merge of rust-lang#127300 - biabbas:fix_connect_timeout, r=tgross35 b889a1d CStr: derive PartialEq, Eq; add test for Ord 3a18110 In connect timeout, read readiness of socket for vxworks. Check pollhup or pollerr for refused connections in linux c4ee91f Merge from rustc 244d843 std: update comments on gcc personality fn d252b6b std: unsafe-wrap gcc::rust_eh_personality and impl 09bda4f Rollup merge of rust-lang#128135 - joboet:reduplicate_tls, r=tgross35 a4c88bc Rollup merge of rust-lang#128046 - GrigorenkoPV:90435, r=tgross35 2614d86 Rollup merge of rust-lang#126548 - rik86189:issue-88264-fix, r=tgross35 75a178f Rollup merge of rust-lang#126042 - davidzeng0:master, r=Amanieu 1e118ae Rollup merge of rust-lang#128131 - ChrisDenton:stuff, r=workingjubilee cea2ca9 Rollup merge of rust-lang#128120 - compiler-errors:async-fn-name, r=oli-obk 92e3688 Rollup merge of rust-lang#127733 - GrigorenkoPV:don't-forget, r=Amanieu 9b1cffd Rollup merge of rust-lang#127480 - biabbas:vxworks, r=workingjubilee 2632261 Rollup merge of rust-lang#127252 - fitzgen:edge-cases-for-bitwise-operations, r=m-ou-se b0d7414 Rollup merge of rust-lang#126152 - RalfJung:size_of_val_raw, r=saethlin 6d0b714 Improved clarity of documentation for std::fs::create_dir_all eb79e09 std: use duplicate thread local state in tests 8456a97 Forbid unsafe_op_in_unsafe_fn in sys/pal/windows 5a9fb1f Import `core::ffi::c_void` in more places 16450f7 Merge from rustc 697c717 Add chroot unsupported implementation for VxWorks 6242470 Rollup merge of rust-lang#128106 - hallfox:patch-1, r=ChrisDenton de086ea Rollup merge of rust-lang#128092 - ChrisDenton:wrappers, r=workingjubilee ccba33c Rollup merge of rust-lang#128043 - safinaskar:primitive, r=workingjubilee a069998 Rollup merge of rust-lang#127481 - a1phyr:pattern_gat, r=Amanieu bc7345c Rollup merge of rust-lang#126770 - wr7:master, r=Amanieu 21f6b65 Rollup merge of rust-lang#125962 - Coekjan:const-binary-heap, r=Amanieu eee5bba Auto merge of rust-lang#127153 - NobodyXu:pipe, r=ChrisDenton fd3a45f Gate AsyncFn* under async_closure feature 0374ea2 Add elem_offset and related methods 2b3eacb library/core/src/primitive.rs: small doc fix 45f80e6 Fix return type of FileAttr methods on AIX target 6cabb65 add `is_multiple_of` for unsigned integer types 4c4a93a Initial implementation of anonymous_pipe 63d2997 Update process vxworks, set default stack size of 256 Kib for vxworks. User can set the stack size using RUST_MIN_STACK, with min size of libc::PTHREAD_STACK_MIN(4kib) ee86041 Rollup merge of rust-lang#128089 - workingjubilee:commonly-wrapped-to-make-safe, r=ChrisDenton ad9a52d Rollup merge of rust-lang#125834 - workingjubilee:weaken-thir-unsafeck-for-addr-of-static-mut, r=compiler-errors 642c69b Remove wrapper functions from c.rs de2a037 std: Unsafe-wrap backtrace code held in-common 155aef9 std: Unsafe-wrap alloc code held in-common bee0155 Cfg disable on_broken_pipe_flag_used() for vxworks 227b5af Disable dirfd for vxworks, Return unsupported error from set_times and lchown for vxworks 22a6797 Allow unused unsafe for vxworks in read_at and write at 8be45a9 Docs for core::primitive: mention that "core" can be shadowed, too, so we should write "::core" c039ee8 library: vary unsafety in bootstrapping for SEH 6765b97 std: unsafe-wrap personality::dwarf::eh 7ae76f0 Rollup merge of rust-lang#128008 - weiznich:fix/121521, r=lcnr 323e962 Rollup merge of rust-lang#127996 - ian-h-chamberlain:fix/horizon-warnings-unsafe-in-unsafe, r=tgross35 ae6187f Rollup merge of rust-lang#127415 - AljoschaMeyer:master, r=dtolnay d6a36f5 Use given allocator instad of Global d0bc9a0 Start using `#[diagnostic::do_not_recommend]` in the standard library ba43261 Rollup merge of rust-lang#127583 - Nilstrieb:invalid-utf8, r=joboet 0727e53 Fix warnings when checking armv6k-nintendo-3ds bbe4da8 Fix some `#[cfg_attr(not(doc), repr(..))]` 321dbf8 Deal with invalid UTF-8 from `gai_strerror` 6aa00e1 std::thread: available_parallelism implementation for vxWorks proposal. 2fff48d Auto merge of rust-lang#127722 - BoxyUwU:new_adt_const_params_limitations, r=compiler-errors d7770e9 Rollup merge of rust-lang#128005 - ChrisDenton:msvc-include, r=joboet 8fdee23 Rollup merge of rust-lang#127734 - ChrisDenton:netc, r=Mark-Simulacrum 3b2536e Remove _tls_used hack 07dbb38 Rollup merge of rust-lang#127873 - workingjubilee:forbid-unsafe-ops-for-kmc-solid, r=Amanieu bd26295 Rollup merge of rust-lang#127843 - workingjubilee:break-up-big-ass-stack-overflow-fn, r=joboet 00b4f61 Inject win arm32 shims into metadata generation 2b62867 Rollup merge of rust-lang#127918 - ChrisDenton:thread-name-string, r=joboet a077eb1 Rollup merge of rust-lang#123196 - Ayush1325:uefi-process, r=joboet eb09be4 std: forbid unwrapped unsafe in unsupported_backslash dcb9854 kmc-solid: forbid(unsafe_op_in_unsafe_fn) 845a2f7 Auto merge of rust-lang#127982 - matthiaskrgr:rollup-nzyvphj, r=matthiaskrgr 00d6fc4 Rollup merge of rust-lang#127978 - nyurik:lib-refs, r=workingjubilee 4d8afcd Avoid ref when using format! for perf 9f20a0f Rollup merge of rust-lang#126199 - ivan-shrimp:nonzero_isqrt, r=tgross35 f06530c Rollup merge of rust-lang#112328 - juliusl:pr/windows-add-change-time, r=ChrisDenton 8d5cf50 uefi: process: Fixes from PR c6cb67c uefi: process: Final Touchups afe1ef0 uefi: process: Add CommandArgs support ef6b173 uefi: process: Add support for args 1991fe3 uefi: process Implement inherit 24a9582 uefi: process: Add null protocol 36a0e1e uefi: process: Add stderr support b712e74 uefi: process: Add support to capture stdout e6eeb4e uefi: Add process f3b1c8a improve safety comment 9348998 add `NonZero<uN>::isqrt` edc4cdc Use `#[rustfmt::skip]` on some `use` groups to prevent reordering. 489f1ef unix: acquire-load NEED_ALTSTACK 9e11e01 unix: Unsafe-wrap stack_overflow::{drop,make}_handler 72c7444 unix: Unsafe-wrap stack_overflow::cleanup 33a32f2 unix: lift init of sigaltstack before sigaction 9fb6e49 unix: Unsafe-wrap stack_overflow::signal_handler c99ebd4 Rollup merge of rust-lang#127594 - c6c7:fuchsia-status-code-match-arm, r=tmandry 8378261 Move ThreadName conversions to &cstr/&str 68e2391 Style change 16bce8a Make `Thread::new_inner` a safe function d1d9893 Rollup merge of rust-lang#127748 - scottmcm:option_len, r=joboet b0c85ba Rollup merge of rust-lang#124881 - Sp00ph:reentrant_lock_tid, r=joboet 7e21850 Update `ReentrantLock` implementation, add `CURRENT_ID` thread local. c10a929 Safely enforce thread name requirements cc4ed95 Rollup merge of rust-lang#127077 - tbu-:pr_doc_fd_to_owned, r=workingjubilee 37d7bff Rollup merge of rust-lang#127861 - Kriskras99:patch-1, r=tgross35 3d50720 Rollup merge of rust-lang#127859 - RalfJung:ptr-dyn-metadata, r=scottmcm 1f3311b Rollup merge of rust-lang#127845 - workingjubilee:actually-break-up-big-ass-stack-overflow-fn, r=joboet 5578593 Auto merge of rust-lang#127865 - matthiaskrgr:rollup-8m49dlg, r=matthiaskrgr 54728b1 feat: adding ext that returns change_time for Windows b164bab Auto merge of rust-lang#125942 - timokroeger:windows-once-futex, r=ChrisDenton 0eda3a3 Rollup merge of rust-lang#127337 - celinval:intrinsics-fallback, r=oli-obk ed3c6d1 Mention how you can go from `BorrowedFd` to `OwnedFd` and back 455bd57 Make language around `ToOwned` for `BorrowedFd` more precise ab7a0d4 Document the column numbers for the dbg! macro 89cd225 ptr::metadata: update comment on vtable_ptr work-around 51e54a4 ptr::metadata: avoid references to extern types be0c06b Split part of `adt_const_params` into `unsized_const_params` 857ed93 Forbid `!Sized` types and references aedc16c unix: unsafe-wrap install_main_guard_default 4db3aa1 unix: clean up install_main_guard_freebsd d167f00 unix: stack_start_aligned is a safe fn 27b79e6 unix: split stack_overflow::install_main_guard by os d50143f Update name of Windows abort constant to match platform documentation cbaa831 Add match arm for Fuchsia status code upon an abort in a test f15715f lib: replace some `mem::forget`'s with `ManuallyDrop` 9bbf09d Windows: move BSD socket shims to netc d76c965 Remove generic lifetime parameter of trait `Pattern` ad3db57 Use Option's discriminant as its size hint 3b86ae3 Explicitly ignore `into_raw_handle()` using `let _ =` in sys/pal/windows. 1cb5354 Add `must_use` to IntoRawFd/IntoRawSocket/IntoRawHandle's methods. 697377a Clarify/add `must_use` messages for more `into_raw*` functions of `alloc` types. a7bec56 size_of_val_raw: for length 0 this is safe to call 39c4daa Reset sigpipe not supported for vxworks ca537d2 Fix them doc examples some more be23cef Fix doc examples 8d01996 Run formatter on alloc/src/boxed.rs c3b602a Add missing try_new_uninit_slice_in and try_new_zeroed_slice_in 5487574 Document safety of a few intrinsics 87fcd2f Move a few intrinsics to use Rust abi 6b549ba mark `can_not_overflow` as `#[rustc_const_stable(...)]` 259c058 stabilize `const_int_from_str` 538fe81 Add edge-case examples to `{count,leading,trailing}_{ones,zeros}` methods 5fc66dd Implement `unsigned_signed_diff` dbbb4ab less garbage, more examples 4952644 update tracking issue for `const_binary_heap_new_in` 33389b0 more explicitly state the basic rules of working with the obtained raw pointers 395ad9f Windows: Use futex implementation for `Once` 7953644 from_ref, from_mut: clarify domain of quantification git-subtree-dir: library git-subtree-split: 9cc3bc6
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #128046, I've spotted a peculiarity:
CStrhasPartialEq, Eq, PartialOrd, Ordimplemented manually and not derived.While we can't derive
PartialOrd, Ord(due to inner[c_char]being[i8]or[u8]on different platforms), we can derivePartialEq, Eq(I think), allowing as to remove#[allow(clippy::derived_hash_with_manual_eq)]as well.(I really hope
c_char: Eqon all platforms)