Skip to content

Use generic impls for Hash #12820

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from
Closed

Use generic impls for Hash #12820

wants to merge 1 commit into from

Conversation

erickt
Copy link
Contributor

@erickt erickt commented Mar 11, 2014

cc @alexcrichton. This is my last outstanding patch from the Hash migration. It adds generic hash impls for many of the stdlib types. We might want to wait until we turn #[feature(default_type_params)]; permanently on though before we land this PR.

@erickt
Copy link
Contributor Author

erickt commented Mar 12, 2014

@alexcrichton: gah! It appears that GitHub no longer shows comments on an old commit after a rebase, and there's no way to see your comment. We might need to rethink how we've been doing reviews if we are going to lose all that comment history.

@alexcrichton
Copy link
Member

It's a sad truth about using github for code review in general sadly, but perhaps I should be more liberal about commenting on the PR instead of specific commits.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants