Skip to content

Delete SimplifyArmIdentity and SimplifyBranchSame tests #128262

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jul 27, 2024

Conversation

dianqk
Copy link
Member

@dianqk dianqk commented Jul 27, 2024

These two passes have already been deleted in #107256. I'm not sure why tidy didn't catch it.

As regression tests, I didn't delete tests/ui/mir/issue-66851.rs and tests/ui/mir/simplify-branch-same.rs.

r? compiler

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 27, 2024
@dianqk dianqk marked this pull request as draft July 27, 2024 06:08
@dianqk dianqk force-pushed the remove-unused-tests branch from a066b7d to 9aed384 Compare July 27, 2024 06:10
@dianqk dianqk marked this pull request as ready for review July 27, 2024 06:11
@jieyouxu
Copy link
Member

r? mir-opt

@rustbot rustbot assigned saethlin and unassigned fmease Jul 27, 2024
@jieyouxu jieyouxu added the A-mir-opt Area: MIR optimizations label Jul 27, 2024
@saethlin
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 27, 2024

📌 Commit 9aed384 has been approved by saethlin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 27, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 27, 2024
Rollup of 8 pull requests

Successful merges:

 - rust-lang#125897 (from_ref, from_mut: clarify documentation)
 - rust-lang#128207 (improve error message when `global_asm!` uses `asm!` options)
 - rust-lang#128241 (Remove logic to suggest clone of function output)
 - rust-lang#128259 ([illumos/solaris] set MSG_NOSIGNAL while writing to sockets)
 - rust-lang#128262 (Delete `SimplifyArmIdentity` and `SimplifyBranchSame` tests)
 - rust-lang#128266 (update `rust.channel` default value documentation)
 - rust-lang#128267 (Add rustdoc GUI test to check title with and without search)
 - rust-lang#128271 (Disable jump threading of float equality)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 356f190 into rust-lang:master Jul 27, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Jul 27, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 27, 2024
Rollup merge of rust-lang#128262 - DianQK:remove-unused-tests, r=saethlin

Delete `SimplifyArmIdentity` and `SimplifyBranchSame` tests

These two passes have already been deleted in rust-lang#107256. I'm not sure why tidy didn't catch it.

As regression tests, I didn't delete `tests/ui/mir/issue-66851.rs` and `tests/ui/mir/simplify-branch-same.rs`.

r? compiler
@dianqk dianqk deleted the remove-unused-tests branch July 28, 2024 03:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-mir-opt Area: MIR optimizations S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants