linker: Remove the "--whole-archive in test mode" backcompat hack

[petrochenkov]

Fixes #116910.

[rustbot]

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[petrochenkov]

@bors try

[bors]

⌛ Trying commit 3d2d7cf with merge 33f1d8b...

[Nadrieril]

r? compiler

[bors]

☀️ Try build successful - checks-actions
Build commit: 33f1d8b (33f1d8bb92813a1bfc23c093c9f443ab09290307)

[petrochenkov]

@craterbot run mode=build-and-test +cargoflags=--no-run

[craterbot]

🚨 Error: failed to parse the command

🆘 If you have any trouble with Crater please ping @rust-lang/infra!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[petrochenkov]

@craterbot run mode=build-and-test

[craterbot]

👌 Experiment pr-128400 created and queued.
🤖 Automatically detected try build 33f1d8b
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🚧 Experiment pr-128400 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🎉 Experiment pr-128400 is completed!
📊 279 regressed and 201 fixed (487456 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[petrochenkov]

Too many spurious regressions, I'll just do a second iteration.
@craterbot run mode=build-and-test p=1 crates=https://crater-reports.s3.amazonaws.com/pr-128400/retry-regressed-list.txt

[craterbot]

👌 Experiment pr-128400-1 created and queued.
🤖 Automatically detected try build 33f1d8b
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🚧 Experiment pr-128400-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[bors]

📌 Commit 3d2d7cf has been approved by bjorn3

It is now in the queue for this repository.

[bors]

⌛ Testing commit 3d2d7cf with merge a733c5b...

[rust-log-analyzer]

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[bjorn3]

@bors retry failed to remove executable with "Access is denied"

[bors]

⌛ Testing commit 3d2d7cf with merge 04dff01...

[bors]

☀️ Test successful - checks-actions
Approved by: bjorn3
Pushing 04dff01 to master...

[rust-timer]

Finished benchmarking commit (04dff01): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.2%, secondary 2.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.2%	[3.2%, 3.2%]	1
Regressions ❌ (secondary)	2.5%	[2.5%, 2.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.2%	[3.2%, 3.2%]	1

Cycles

Results (secondary -4.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.4%	[-4.4%, -4.3%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 758.54s -> 756.781s (-0.23%)
Artifact size: 339.24 MiB -> 339.30 MiB (0.02%)

[nyurik]

@petrochenkov I hit an issue with this - my project has a large cmake-based C++ code, and I'm trying to write a Rust wrapper using cxx bridge. cargo test was passing on older Rust, but unexpectedly failed with 1.82+ until I saw that kuzu project also did a hack here, which did work. This seems like a major hack - is this the expected usage of this feature?

if rustversion::cfg!(since(1.82)) {
    println!("cargo:rustc-link-lib=static:+whole-archive=kuzu");
} else {
    println!("cargo:rustc-link-lib=static=kuzu");
}

[petrochenkov]

The recommended fixes are the same as in https://doc.rust-lang.org/beta/releases.html#compatibility-notes-21.
It's more likely that some native dependencies should be reordered, and less likely that +whole-archive needs to be added (which can be done unconditionally, without a version check). I cannot say which alternative is appropriate without looking at the specific libraries in more detail.