-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Update run-make/used to use any_symbol_contains
#128603
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
This PR modifies cc @jieyouxu |
@bors try |
Update run-make/used to use `any_symbol_contains` This makes it so we don't need `nm` or `llvm-nm`. I also tested that `BAR` is removed. I'm not sure if this is wanted though. try-job: x86_64-msvc try-job: i686-msvc
I'm inclined to say we probably don't care if |
Fair. I do wonder why we have |
It's possible that it's due to |
I mean we could just delete this line in used.rs and it won't make any difference to the test: rust/tests/run-make/used/used.rs Line 6 in a604303
|
Yeah, that seems reasonable to me 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, r=me if try jobs come back green 👍
@bors r=jieyouxu |
Update run-make/used to use `any_symbol_contains` This makes it so we don't need `nm` or `llvm-nm`. I also tested that `BAR` is removed. I'm not sure if this is wanted though.
Rollup of 6 pull requests Successful merges: - rust-lang#127095 (Migrate `reproducible-build-2` and `stable-symbol-names` `run-make` tests to rmake) - rust-lang#127921 (Stabilize unsafe extern blocks (RFC 3484)) - rust-lang#128466 (Update the stdarch submodule) - rust-lang#128530 (Implement `UncheckedIterator` directly for `RepeatN`) - rust-lang#128581 (Assert that all attributes are actually checked via `CheckAttrVisitor` and aren't accidentally usable on completely unrelated HIR nodes) - rust-lang#128603 (Update run-make/used to use `any_symbol_contains`) Failed merges: - rust-lang#128410 (Migrate `remap-path-prefix-dwarf` `run-make` test to rmake) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#127921 (Stabilize unsafe extern blocks (RFC 3484)) - rust-lang#128283 (bootstrap: fix bug preventing the use of custom targets) - rust-lang#128530 (Implement `UncheckedIterator` directly for `RepeatN`) - rust-lang#128551 (chore: refactor backtrace style in panic) - rust-lang#128573 (Simplify `body` usage in rustdoc) - rust-lang#128581 (Assert that all attributes are actually checked via `CheckAttrVisitor` and aren't accidentally usable on completely unrelated HIR nodes) - rust-lang#128603 (Update run-make/used to use `any_symbol_contains`) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#128603 - ChrisDenton:used, r=jieyouxu Update run-make/used to use `any_symbol_contains` This makes it so we don't need `nm` or `llvm-nm`. I also tested that `BAR` is removed. I'm not sure if this is wanted though.
This makes it so we don't need
nm
orllvm-nm
.I also tested that
BAR
is removed. I'm not sure if this is wanted though.