Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Revert recent changes to dead code analysis (beta flavor) #128606

Merged
merged 5 commits into from
Aug 5, 2024
Merged

Revert recent changes to dead code analysis (beta flavor) #128606

merged 5 commits into from
Aug 5, 2024

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Aug 3, 2024 •
edited
Loading

This PR cherry-picks the subset of #128404 which actually applies to beta, namely:

And then re-blesses tests.

I opted to do a manual backport of that PR since preparing the revert correctly was quite a hassle.

r? @cuviper (or anyone on release)

@compiler-errors
Revert "Rollup merge of rust-lang#127107 - mu001999-contrib:dead/enha…
d99ba60 
…nce-2, r=pnkfelix"

This reverts commit 31fe962, reversing
changes made to f203078.
@compiler-errors
Revert "Rollup merge of rust-lang#126618 - mu001999-contrib:dead/enha…
d571104 
…nce, r=pnkfelix"

This reverts commit 2724aea, reversing
changes made to d929a42.
@compiler-errors
Revert "Rollup merge of rust-lang#126315 - mu001999-contrib:fix/12628…
ad90fa6 
…9, r=petrochenkov"

This reverts commit 977c5fd, reversing
changes made to 24c94f0.
@compiler-errors
Revert "Rollup merge of rust-lang#125572 - mu001999-contrib:dead/enha…
35779db 
…nce, r=pnkfelix"

This reverts commit 13314df, reversing
changes made to 6e534c7.
@compiler-errors
Bless test fallout
eeaf3ce
@rustbot
Copy link
Collaborator

rustbot commented Aug 3, 2024

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 3, 2024
@compiler-errors compiler-errors mentioned this pull request Aug 3, 2024
Closed
@cuviper
Copy link
Member

cuviper commented Aug 3, 2024

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Aug 3, 2024

📌 Commit eeaf3ce has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2024
@bors
Copy link
Contributor

bors commented Aug 5, 2024

⌛ Testing commit eeaf3ce with merge 2059132...

@bors
Copy link
Contributor

bors commented Aug 5, 2024

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 2059132 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 5, 2024
@bors bors merged commit 2059132 into rust-lang:beta Aug 5, 2024
7 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Aug 5, 2024
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Sep 2, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.
4 participants
@compiler-errors @rustbot @cuviper @bors