Don't inline tainted MIR bodies #128616
Merged
Don't inline tainted MIR bodies #128616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
rustbot
added
S-waiting-on-review
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
cjgillot
reviewed
Aug 3, 2024
|
r? cjgillot |
compiler-errors
force-pushed
the
mir-inline-tainted
branch
from
309401e to
647ef22
Compare
|
also fixes #122909 ? |
|
☔ The latest upstream changes (presumably #128835) made this pull request unmergeable. Please resolve the merge conflicts. |
|
R=me after rebase |
compiler-errors
force-pushed
the
mir-inline-tainted
branch
from
647ef22 to
65b029b
Compare
|
@bors r=cjgillot |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 9, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#128616 (Don't inline tainted MIR bodies) - rust-lang#128804 (run-make: enable msvc for redundant-libs) - rust-lang#128823 (run-make: enable msvc for staticlib-dylib-linkage) - rust-lang#128824 (Update compiler-builtins version to 0.1.118) Failed merges: - rust-lang#128410 (Migrate `remap-path-prefix-dwarf` `run-make` test to rmake) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 9, 2024
Rollup merge of rust-lang#128616 - compiler-errors:mir-inline-tainted, r=cjgillot Don't inline tainted MIR bodies Don't inline MIR bodies that are tainted, since they're not necessarily well-formed. Fixes rust-lang#128601 (I didn't add a new test, just copied one from the crashes, since they're the same root cause). Fixes rust-lang#122909.
|
This is perhaps a dumb question, but why are any optimizations performed at all when errors are present? |
|
When all errors are present? Because we don't want global state to affect local computations, iirc. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't inline MIR bodies that are tainted, since they're not necessarily well-formed.
Fixes #128601 (I didn't add a new test, just copied one from the crashes, since they're the same root cause).
Fixes #122909.