-
Notifications
You must be signed in to change notification settings - Fork 13.3k
handle crates when they are not specified for std docs #128631
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
ebaea3d
to
5f0e0a6
Compare
This fixes a regression from rust-lang#128182. Signed-off-by: onur-ozkan <work@onurozkan.dev>
question (as someone who doesn’t understand bootstrap/rustup components): is it possible to add a test for this? can we ensure that the |
There are a few ways to test it, but I wasn't sure where to handle/test it. The best way might be to mock the bootstrap tests, but that requires huge work. This should be enough until then. |
@bors r+ |
handle crates when they are not specified for std docs Fixes a regression from rust-lang#128182. Resolves rust-lang#128610
This comment has been minimized.
This comment has been minimized.
Actual failure:
|
@bors r- rollup=iffy |
@bors r=Mark-Simulacrum rollup |
handle crates when they are not specified for std docs Fixes a regression from rust-lang#128182. Resolves rust-lang#128610
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#127655 (turn `invalid_type_param_default` into a `FutureReleaseErrorReportInDeps`) - rust-lang#127974 (force compiling std from source if modified) - rust-lang#128026 (std::thread: available_parallelism implementation for vxWorks proposal.) - rust-lang#128309 (Implement cursors for `BTreeSet`) - rust-lang#128500 (Add test for updating enum discriminant through pointer) - rust-lang#128630 (docs(resolve): more explain about `target`) - rust-lang#128631 (handle crates when they are not specified for std docs) - rust-lang#128638 (run-make: enable msvc for `link-dedup`) r? `@ghost` `@rustbot` modify labels: rollup
@bors r- rollup=never |
for f in ["alloc.json", "core.json", "std.json"] { | ||
assert!(out.join(f).exists(), "rust-docs-json is missing `{f}`."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we should do this only for the t1 targets?
@rustbot ready |
Reverted 2nd commit to unblock this hotfix. We can add that sanity check later. @bors r=Mark-Simulacrum rollup |
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#128385 (rustdoc-json: discard non-local inherent impls for primitives) - rust-lang#128559 (Don't re-elaborated already elaborated caller bounds in method probe) - rust-lang#128631 (handle crates when they are not specified for std docs) - rust-lang#128664 (Add `Debug` impls to API types in `rustc_codegen_ssa`) - rust-lang#128686 (fix the invalid argument type) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#128631 - onur-ozkan:hotfix, r=Mark-Simulacrum handle crates when they are not specified for std docs Fixes a regression from rust-lang#128182. Resolves rust-lang#128610
Fixes a regression from #128182.
Resolves #128610