-
Notifications
You must be signed in to change notification settings - Fork 13.4k
bump conflicting_repr_hints lint to be shown in dependencies #128727
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
bump conflicting_repr_hints lint to be shown in dependencies #128727
Conversation
r=me on the change, I think this change needs a compiler fcp, doesn't it? |
Either compiler or lang. Not certain where it falls on the spectrum, given it's linting against something that (afaict?) was a compiler mistake to ever accept IMO. I guess compiler is fine, though. Also, could we make this FCP apply to both bumping this to a FCW-in-deps now and bumping this to a hard error later? I don't believe it needs two FCPs. |
cc @rust-lang/compiler on whether you think this needs an FCP. The actual change feels very much t-compiler to me |
intend to merge this PR in a few days without an FCP unless there's any pushback here. Started a zulip thread about the general procedure here https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/FCP.20for.20bumping.20lints @RalfJung feel free to ping me if I forget or just r+ it yourself then |
I think it's fine to start reporting this future compatibility lint without an FCP. I do think whenever we turn this into a hard error, we should do an FCP at that point. |
"a few days" have passed and the only comment was approving, so let's land this. |
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#128727 (bump conflicting_repr_hints lint to be shown in dependencies) - rust-lang#129232 (Fix `thread::sleep` Duration-handling for ESP-IDF) - rust-lang#129321 (Change neutral element of <fNN as iter::Sum> to neg_zero) - rust-lang#129353 (llvm-wrapper: adapt for LLVM 20 API changes) - rust-lang#129363 (Force `LC_ALL=C` for all run-make tests) - rust-lang#129364 (safe transmute: gracefully bubble-up layout errors) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#128727 - RalfJung:conflicting-repr-future-incompat, r=lcnr bump conflicting_repr_hints lint to be shown in dependencies This has been a future compatibility lint for years, let's bump it up to be shown in dependencies (so that hopefully we can then make it a hard error fairly soon). Cc rust-lang#68585
This has been a future compatibility lint for years, let's bump it up to be shown in dependencies (so that hopefully we can then make it a hard error fairly soon).
Cc #68585