Skip to content

rustdoc-json: add a test for impls on private & hidden types #128836

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

its-the-shrimp
Copy link
Contributor

Fixes #107278 (or rather just ensures it won't resurface)
r? @aDotInTheVoid

@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 8, 2024
@its-the-shrimp its-the-shrimp changed the title rustdoc-json: add a test for #107278 rustdoc-json: add a test for impls on private & hidden types Aug 8, 2024
@aDotInTheVoid
Copy link
Member

r=me when CI passes

@bors delegate+ rollup=always

@bors
Copy link
Collaborator

bors commented Aug 8, 2024

✌️ @its-the-shrimp, you can now approve this pull request!

If @aDotInTheVoid told you to "r=me" after making some further change, please make that change, then do @bors r=@aDotInTheVoid

@its-the-shrimp
Copy link
Contributor Author

@bors r=@aDotInTheVoid

@bors
Copy link
Collaborator

bors commented Aug 8, 2024

📌 Commit 1bf30eb has been approved by aDotInTheVoid

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 8, 2024
…, r=aDotInTheVoid

rustdoc-json: add a test for impls on private & hidden types

Fixes rust-lang#107278 (or rather just ensures it won't resurface)
r? `@aDotInTheVoid`
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 9, 2024
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#128640 (rwlock: disable 'frob' test in Miri on macOS)
 - rust-lang#128791 (Don't implement `AsyncFn` for `FnDef`/`FnPtr` that wouldnt implement `Fn`)
 - rust-lang#128806 (Split `ColorConfig` off of `HumanReadableErrorType`)
 - rust-lang#128818 (std float tests: special-case Miri in feature detection)
 - rust-lang#128834 (rustdoc: strip unreachable modules)
 - rust-lang#128836 (rustdoc-json: add a test for impls on private & hidden types)
 - rust-lang#128837 (Clippy subtree update)
 - rust-lang#128851 (Add comment that bors did not see pushed before it merged)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8789b95 into rust-lang:master Aug 9, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 9, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 9, 2024
Rollup merge of rust-lang#128836 - its-the-shrimp:add_test_for_107278, r=aDotInTheVoid

rustdoc-json: add a test for impls on private & hidden types

Fixes rust-lang#107278 (or rather just ensures it won't resurface)
r? ``@aDotInTheVoid``
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#[doc(hidden)] causes type's traits to disappear from rustdoc JSON built with --document-hidden-items
4 participants