rust-analyzer: use in-tree pattern_analysis crate
#128922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed to set assignee to
|
rustbot
added
the
S-waiting-on-review
|
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
fbstj
reviewed
Aug 10, 2024
Nadrieril
force-pushed
the
r-a-use-upstream-pat-ana
branch
from
eecad10 to
d340d51
Compare
Shouldn't I qualify for that first one? 🤔 |
This comment has been minimized.
This comment has been minimized.
|
r? @Veykril |
Nadrieril
force-pushed
the
r-a-use-upstream-pat-ana
branch
from
d340d51 to
acb0ecc
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 11, 2024
…, r=Veykril rust-analyzer: use in-tree `pattern_analysis` crate r? `@Veykril`
|
@bors r- |
bors
added
S-waiting-on-author
|
rust-lang/rust-analyzer#17853 fixes the mismatches on our side now, so we should probably switch this to in-tree once that is merged and we've synced the subtree again |
|
Makes sense. Marking as draft in the meantime. |
|
The sync PR got merged today, we should be good to go? |
|
Oh, perfect! |
Nadrieril
force-pushed
the
r-a-use-upstream-pat-ana
branch
from
acb0ecc to
bb84372
Compare
lnicola
approved these changes
Aug 14, 2024
|
@bors r+ |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 15, 2024
…, r=Veykril rust-analyzer: use in-tree `pattern_analysis` crate r? `@Veykril`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 15, 2024
…llaumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#128348 (Unconditionally allow shadow call-stack sanitizer for AArch64) - rust-lang#128922 (rust-analyzer: use in-tree `pattern_analysis` crate) - rust-lang#128935 (More work on `zstd` compression) - rust-lang#129072 (Infer async closure args from `Fn` bound even if there is no corresponding `Future` bound on return) - rust-lang#129101 (Fix projections when parent capture is by-ref but child capture is by-value in the `ByMoveBody` pass) - rust-lang#129106 (Remove redundant type ops: `Eq`/`Subtype`) - rust-lang#129122 (Remove duplicated `Rustdoc::output` method from `run-make-support` lib) - rust-lang#129124 (rustdoc-json: Use FxHashMap from rustdoc_json_types) r? `@ghost` `@rustbot` modify labels: rollup
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Aug 16, 2024
…, r=Veykril rust-analyzer: use in-tree `pattern_analysis` crate r? `@Veykril`
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Aug 16, 2024
…, r=Veykril rust-analyzer: use in-tree `pattern_analysis` crate r? ``@Veykril``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 16, 2024
…kingjubilee Rollup of 10 pull requests Successful merges: - rust-lang#128064 (Improve docs for Waker::noop and LocalWaker::noop) - rust-lang#128922 (rust-analyzer: use in-tree `pattern_analysis` crate) - rust-lang#128965 (Remove `print::Pat` from the printing of `WitnessPat`) - rust-lang#128977 (Only try to modify file times of a writable file on Windows) - rust-lang#129018 (Migrate `rlib-format-packed-bundled-libs` and `native-link-modifier-bundle` `run-make` tests to rmake) - rust-lang#129037 (Port `run-make/libtest-json` and `run-make/libtest-junit` to rmake) - rust-lang#129078 (`ParamEnvAnd::fully_perform`: we have an `ocx`, use it) - rust-lang#129110 (Add a comment explaining the return type of `Ty::kind`.) - rust-lang#129111 (Port the `sysroot-crates-are-unstable` Python script to rmake) - rust-lang#129135 (crashes: more tests) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 16, 2024
…kingjubilee Rollup of 9 pull requests Successful merges: - rust-lang#128064 (Improve docs for Waker::noop and LocalWaker::noop) - rust-lang#128922 (rust-analyzer: use in-tree `pattern_analysis` crate) - rust-lang#128965 (Remove `print::Pat` from the printing of `WitnessPat`) - rust-lang#129018 (Migrate `rlib-format-packed-bundled-libs` and `native-link-modifier-bundle` `run-make` tests to rmake) - rust-lang#129037 (Port `run-make/libtest-json` and `run-make/libtest-junit` to rmake) - rust-lang#129078 (`ParamEnvAnd::fully_perform`: we have an `ocx`, use it) - rust-lang#129110 (Add a comment explaining the return type of `Ty::kind`.) - rust-lang#129111 (Port the `sysroot-crates-are-unstable` Python script to rmake) - rust-lang#129135 (crashes: more tests) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 16, 2024
Rollup merge of rust-lang#128922 - Nadrieril:r-a-use-upstream-pat-ana, r=Veykril rust-analyzer: use in-tree `pattern_analysis` crate r? ```@Veykril```
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Veykril